Skip to content

Commit a2f4b7f

Browse files
Bring device_mesh=None to FSDPUlyssesShardingManager when SP is not enable
1 parent 1dabdda commit a2f4b7f

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

verl/workers/engine/veomni/transformer_impl.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,11 @@ def __init__(
9595
self._is_offload_optimizer = self.engine_config.optimizer_offload
9696
self._is_lora = self.model_config.lora_rank > 0
9797

98-
self.ulysses_sharding_manager = FSDPUlyssesShardingManager(parallel_state.get_parallel_state().device_mesh)
9998
self.use_ulysses_sp = parallel_state.get_parallel_state().sp_enabled
99+
if self.use_ulysses_sp:
100+
self.ulysses_sharding_manager = FSDPUlyssesShardingManager(parallel_state.get_parallel_state().device_mesh)
101+
else:
102+
self.ulysses_sharding_manager = FSDPUlyssesShardingManager(None)
100103

101104
if self.engine_config.entropy_from_logits_with_chunking:
102105
entropy_from_logits = verl_F.entropy_from_logits_with_chunking

0 commit comments

Comments
 (0)