Skip to content

Commit d9d98b4

Browse files
huydhnpytorchmergebot
authored andcommitted
Skip DNS host fix on ROCm runners (pytorch#100861)
The quick fix in pytorch#100507 is only needed on Linux runners, not ROCm as the latter doesn't have the corresponding step in [setup-linux](pytorch#100436). ROCm runners use `setup-rocm` action instead, and it doesn't seem to have any issue with DNS, so there is no need to add the quick fix to ROCm. This is currently breaking ROCm binary test job in trunk, for example https://github.com/pytorch/pytorch/actions/runs/4905878029/jobs/8761271482. Pull Request resolved: pytorch#100861 Approved by: https://github.com/ZainRizvi, https://github.com/jithunnair-amd
1 parent aaa1323 commit d9d98b4

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

.github/actions/test-pytorch-binary/action.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,12 @@ runs:
3434
-w / \
3535
"${DOCKER_IMAGE}"
3636
)
37-
# Propagate download.pytorch.org IP to container
38-
grep download.pytorch.org /etc/hosts | docker exec -i "${container_name}" bash -c "/bin/cat >> /etc/hosts"
37+
38+
if [[ "${GPU_ARCH_TYPE}" != "rocm" ]]; then
39+
# Propagate download.pytorch.org IP to container. This is only needed on Linux runner
40+
grep download.pytorch.org /etc/hosts | docker exec -i "${container_name}" bash -c "/bin/cat >> /etc/hosts"
41+
fi
42+
3943
docker exec -t -w "${PYTORCH_ROOT}" "${container_name}" bash -c "bash .circleci/scripts/binary_populate_env.sh"
4044
# Generate test script
4145
docker exec -t -w "${PYTORCH_ROOT}" -e OUTPUT_SCRIPT="/run.sh" "${container_name}" bash -c "bash .circleci/scripts/binary_linux_test.sh"

0 commit comments

Comments
 (0)