Skip to content

Commit 219efce

Browse files
authored
Cover more tests with leak tracking. (flutter#134363)
1 parent 6de4e16 commit 219efce

37 files changed

+349
-325
lines changed

packages/flutter/test/material/about_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1460,7 +1460,7 @@ void main() {
14601460
expect(find.text('Exception: Injected failure'), findsOneWidget);
14611461
});
14621462

1463-
testWidgets('Material2 - LicensePage master view layout position - ltr', (WidgetTester tester) async {
1463+
testWidgetsWithLeakTracking('Material2 - LicensePage master view layout position - ltr', (WidgetTester tester) async {
14641464
const TextDirection textDirection = TextDirection.ltr;
14651465
const Size defaultSize = Size(800.0, 600.0);
14661466
const Size wideSize = Size(1200.0, 600.0);
@@ -1592,7 +1592,7 @@ void main() {
15921592
expect(tester.getCenter(find.byType(ListView)), const Offset(160, 356));
15931593
});
15941594

1595-
testWidgets('Material2 - LicensePage master view layout position - rtl', (WidgetTester tester) async {
1595+
testWidgetsWithLeakTracking('Material2 - LicensePage master view layout position - rtl', (WidgetTester tester) async {
15961596
const TextDirection textDirection = TextDirection.rtl;
15971597
const Size defaultSize = Size(800.0, 600.0);
15981598
const Size wideSize = Size(1200.0, 600.0);
@@ -1657,7 +1657,7 @@ void main() {
16571657
expect(tester.getCenter(find.byType(ListView)), const Offset(1040.0, 356.0));
16581658
});
16591659

1660-
testWidgets('Material3 - LicensePage master view layout position - rtl', (WidgetTester tester) async {
1660+
testWidgetsWithLeakTracking('Material3 - LicensePage master view layout position - rtl', (WidgetTester tester) async {
16611661
const TextDirection textDirection = TextDirection.rtl;
16621662
const Size defaultSize = Size(800.0, 600.0);
16631663
const Size wideSize = Size(1200.0, 600.0);
@@ -1724,7 +1724,7 @@ void main() {
17241724
expect(tester.getCenter(find.byType(ListView)), const Offset(1040.0, 356.0));
17251725
});
17261726

1727-
testWidgets('License page title in lateral UI does not use AppBarTheme.foregroundColor', (WidgetTester tester) async {
1727+
testWidgetsWithLeakTracking('License page title in lateral UI does not use AppBarTheme.foregroundColor', (WidgetTester tester) async {
17281728
// This is a regression test for https://github.com/flutter/flutter/issues/108991
17291729
final ThemeData theme = ThemeData(
17301730
appBarTheme: const AppBarTheme(foregroundColor: Color(0xFFFFFFFF)),

packages/flutter/test/material/bottom_sheet_test.dart

Lines changed: 55 additions & 55 deletions
Large diffs are not rendered by default.

packages/flutter/test/material/bottom_sheet_theme_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ void main() {
170170
expect(material.clipBehavior, clipBehavior);
171171
});
172172

173-
testWidgets('Modal bottom sheet-specific parameters are used for modal bottom sheets', (WidgetTester tester) async {
173+
testWidgetsWithLeakTracking('Modal bottom sheet-specific parameters are used for modal bottom sheets', (WidgetTester tester) async {
174174
const double modalElevation = 5.0;
175175
const double persistentElevation = 7.0;
176176
const Color modalBackgroundColor = Colors.yellow;
@@ -249,7 +249,7 @@ void main() {
249249
expect(material.color, null);
250250
});
251251

252-
testWidgets('Modal bottom sheets respond to theme changes', (WidgetTester tester) async {
252+
testWidgetsWithLeakTracking('Modal bottom sheets respond to theme changes', (WidgetTester tester) async {
253253
const double lightElevation = 5.0;
254254
const double darkElevation = 3.0;
255255
const Color lightBackgroundColor = Colors.green;

packages/flutter/test/material/button_theme_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import 'package:flutter/material.dart';
66
import 'package:flutter_test/flutter_test.dart';
7+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
78

89

910
void main() {
@@ -67,7 +68,7 @@ void main() {
6768
expect(theme.colorScheme, const ColorScheme.dark());
6869
});
6970

70-
testWidgets('ButtonTheme alignedDropdown', (WidgetTester tester) async {
71+
testWidgetsWithLeakTracking('ButtonTheme alignedDropdown', (WidgetTester tester) async {
7172
final Key dropdownKey = UniqueKey();
7273

7374
Widget buildFrame({ required bool alignedDropdown, required TextDirection textDirection }) {

packages/flutter/test/material/drawer_test.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ void main() {
213213
expect(state.isEndDrawerOpen, equals(false));
214214
});
215215

216-
testWidgets('Scaffold.drawer - null restorationId ', (WidgetTester tester) async {
216+
testWidgetsWithLeakTracking('Scaffold.drawer - null restorationId ', (WidgetTester tester) async {
217217
final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
218218
await tester.pumpWidget(
219219
MaterialApp(
@@ -236,7 +236,7 @@ void main() {
236236
expect(find.text('drawer'), findsNothing);
237237
});
238238

239-
testWidgets('Scaffold.endDrawer - null restorationId ', (WidgetTester tester) async {
239+
testWidgetsWithLeakTracking('Scaffold.endDrawer - null restorationId ', (WidgetTester tester) async {
240240
final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
241241
await tester.pumpWidget(
242242
MaterialApp(
@@ -259,7 +259,7 @@ void main() {
259259
expect(find.text('endDrawer'), findsNothing);
260260
});
261261

262-
testWidgets('Scaffold.drawer state restoration test', (WidgetTester tester) async {
262+
testWidgetsWithLeakTracking('Scaffold.drawer state restoration test', (WidgetTester tester) async {
263263
final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
264264
await tester.pumpWidget(
265265
MaterialApp(
@@ -290,7 +290,7 @@ void main() {
290290
expect(find.text('drawer'), findsOneWidget);
291291
});
292292

293-
testWidgets('Scaffold.endDrawer state restoration test', (WidgetTester tester) async {
293+
testWidgetsWithLeakTracking('Scaffold.endDrawer state restoration test', (WidgetTester tester) async {
294294
final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
295295
await tester.pumpWidget(
296296
MaterialApp(
@@ -321,7 +321,7 @@ void main() {
321321
expect(find.text('endDrawer'), findsOneWidget);
322322
});
323323

324-
testWidgets('Both drawer and endDrawer state restoration test', (WidgetTester tester) async {
324+
testWidgetsWithLeakTracking('Both drawer and endDrawer state restoration test', (WidgetTester tester) async {
325325
final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
326326
await tester.pumpWidget(
327327
MaterialApp(

0 commit comments

Comments
 (0)