Skip to content

--ignore not working with wildcards after recent refactor #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukebakken opened this issue Oct 22, 2019 · 3 comments · Fixed by #36
Closed

--ignore not working with wildcards after recent refactor #35

lukebakken opened this issue Oct 22, 2019 · 3 comments · Fixed by #36

Comments

@lukebakken
Copy link

To reproduce:

vim_erlang_tags.erl --ignore '*/dialyzer/*'

Output:

File ""*/dialyzer/*"" is not a proper file.

Caused by this commit:

1fb0a9d

https://github.com/vim-erlang/vim-erlang-tags/blob/master/bin/vim_erlang_tags.erl#L249-L258

The previous behavior allowed for wildcards, as indicated by the help doc:

  -i, --ignore FILE_WILDCARD
                Ignore the files/directories that match the given wildcard.
                Read http://www.erlang.org/doc/man/filelib.html#wildcard-1 for
                the wildcard patterns.
@lukebakken
Copy link
Author

@NelsonVides I thought I'd bring this to your attention. Thanks!

@lukebakken lukebakken changed the title --ignore not working after recent refactor --ignore not working with wildcards after recent refactor Oct 22, 2019
@NelsonVides
Copy link
Contributor

@lukebakken Ah, I see what happened! That reminds me, that the best thing this repo needs next is proper testing. I just didn't try wildcards 😢
I'm fixing this asap, hold on!

@NelsonVides
Copy link
Contributor

@lukebakken solved on #36, just wait for merge ;)

@hcs42 hcs42 closed this as completed in #36 Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants