fix: don't replace process.env if process not global variable (#3703)

Author: cawa-93

packages/playground/define/__tests__/define.spec.ts

@@ -11,4 +11,7 @@ test('string', async () => {
   expect(await page.textContent('.env-var')).toBe(
     JSON.parse(defines['process.env.SOMEVAR'])
   )
+  expect(await page.textContent('.process-as-property')).toBe(
+    defines.__OBJ__.process.env.SOMEVAR
+  )
 })

packages/playground/define/index.html

@@ -6,6 +6,7 @@ <h1>Define</h1>
 <p>Boolean <code class="boolean"></code></p>
 <p>Object <span class="pre object"></span></p>
 <p>Env Var <code class="env-var"></code></p>
+<p>process as property: <code class="process-as-property"></code></p>
 
 <script type="module">
   text('.exp', __EXP__)
@@ -14,6 +15,7 @@ <h1>Define</h1>
   text('.boolean', __BOOLEAN__)
   text('.object', JSON.stringify(__OBJ__, null, 2))
   text('.env-var', process.env.SOMEVAR)
+  text('.process-as-property', __OBJ__.process.env.SOMEVAR)
 
   function text(el, text) {
     document.querySelector(el).textContent = text

packages/playground/define/vite.config.js

@@ -8,6 +8,11 @@ module.exports = {
       foo: 1,
       bar: {
         baz: 2
+      },
+      process: {
+        env: {
+          SOMEVAR: '"PROCESS MAY BE PROPERTY"'
+        }
       }
     },
     'process.env.SOMEVAR': '"SOMEVAR"'

packages/vite/src/node/plugins/define.ts

@@ -32,13 +32,21 @@ export function definePlugin(config: ResolvedConfig): Plugin {
 
   const replacements: Record<string, string | undefined> = {
     'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV || config.mode),
+    'global.process.env.NODE_ENV': JSON.stringify(
+      process.env.NODE_ENV || config.mode
+    ),
+    'globalThis.process.env.NODE_ENV': JSON.stringify(
+      process.env.NODE_ENV || config.mode
+    ),
     ...userDefine,
     ...importMetaKeys,
-    'process.env.': `({}).`
+    'process.env.': `({}).`,
+    'global.process.env.': `({}).`,
+    'globalThis.process.env.': `({}).`
   }
 
   const pattern = new RegExp(
-    '\\b(' +
+    '(?<!\\.)\\b(' +
       Object.keys(replacements)
         .map((str) => {
           return str.replace(/[-[\]/{}()*+?.\\^$|]/g, '\\$&')