fix(create-vite): add rel="noreferrer" to elements with target="_blank"#10675
Merged
Conversation
Member
|
Let's hold this for a while because this issue is still being discussed in the svelte repo and may be reverted: sveltejs/svelte#6289 (comment) |
Contributor
Author
|
Yes, it is possible that it will eventually return to normal, but if it does not return to normal immediately, this response should be merged. It is obviously noise to see this warning on a project that has just been initially set up. If you plan to revert back in Svelte 4, it will be after next year as far as I know. |
Member
|
Thanks for the information. So, even though the default template created by Vite does not support IE 11, the svelte compiler does by default, and there seems to be no easy way to turn off this warning… Then I think we have to accept this workaround. |
haoqunjiang
approved these changes
Oct 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixed a warning that occurred when using
<a target="_blank">withoutrel="noreferrer"due to a change in sveltejs/svelte#6188 released in Svelte v3.52.0.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).