test: use default import for fs-extra#11543
Merged
sapphi-red merged 2 commits intoJan 4, 2023
Merged
Conversation
bluwy
previously approved these changes
Jan 1, 2023
Member
Author
|
Ah, no, github actions is working correctly. The "Build&Test" jobs are not running because #11294 splitted the CI into two jobs. |
ArnaudBarre
previously approved these changes
Jan 1, 2023
Member
0dac13a to
6d1b721
Compare
ArnaudBarre
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes this CI fail.
https://github.com/vitejs/vite/actions/runs/3811060325/jobs/6483511814
This fail is caused by vitest-dev/vitest#2512, a breaking change in vitest 0.26.0. (Because we now use vitest 0.25.x the test is passing.)
This test was relying on an invalid named exports. This PR changes that part to use the default export.
#11419 seems not to work even with this PR. I guess it's microsoft/playwright#19661.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).