style(create-vite): use quotes for attributes consistently#12383
Merged
bluwy merged 1 commit intoMar 12, 2023
Conversation
As part of my changes in vitejs#12374, I unintentionally removed the quotes for the Vite logos from the vanilla templates, perhaps because the rest of the templates didn't need them. While HTML5 allows no quotes for attribute values if the value doesn't contain a space, keeping a consistent style is important for cognitive load when reading and maintaining. Hence, I've marked this as a style change. While not a functional change in these templates, it could be if someone later changed the import path to contain a space (perhaps after generating a project using the template).
|
|
bluwy
approved these changes
Mar 12, 2023
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
Ah I didn't notice this. Thanks for following up on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of my changes in #12374, I unintentionally removed the quotes for the Vite logos from the vanilla templates, perhaps because the rest of the templates didn't need them.
While HTML5 allows no quotes for attribute values if the value doesn't contain a space, keeping a consistent style is important for cognitive load when reading and maintaining. Hence, I've marked this as a style change.
While not a functional change in these templates, it could be if someone later changed the import path to contain a space (perhaps after generating a project using the template).
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).