fix(create-vite): remove redundant tsconfig include configuration#14256
Merged
Conversation
|
|
Member
|
Looks good to me, can you make the same change for the svelte template too? |
Contributor
Author
Of course, if you guys think it would help |
bluwy
approved these changes
Sep 4, 2023
Member
|
Thanks! |
bluwy
added a commit
to bluwy/create-vite-extra
that referenced
this pull request
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
"src/**/*.d.ts"configuration seems redundant.Because
"src/**/*.ts"can actually match to.d.tsfiles.The description of include configuration on the Typescript official website is:
"e.g. .ts, .tsx, and .d.ts by default", but this does not mean that after you configure include in tsconfig.json, you must put"src/**/*.ts"and"src/**/*.d.ts"are configured.I have tested that
"src/**/*.ts"can match the.d.tsfile in the project.Or is this intentionally set by the vite team so that developers can directly see that the
.d.tsfile can be resolved by Typescript?Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).