Skip to content

feat(cli): allow initializing non-empty directory#15272

Merged
patak-cat merged 3 commits into
vitejs:mainfrom
SholomAber:initialize-in-non-empty
Dec 12, 2023
Merged

feat(cli): allow initializing non-empty directory#15272
patak-cat merged 3 commits into
vitejs:mainfrom
SholomAber:initialize-in-non-empty

Conversation

@SholomAber
Copy link
Copy Markdown
Contributor

@SholomAber SholomAber commented Dec 7, 2023

Description

closes #12958

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Copy Markdown
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, but otherwise looks great 👍

Comment thread packages/create-vite/src/index.ts Outdated
@SholomAber SholomAber requested a review from bluwy December 7, 2023 14:47
@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Dec 12, 2023
@patak-cat patak-cat merged commit 00669e1 into vitejs:main Dec 12, 2023
@patak-cat
Copy link
Copy Markdown
Member

Thanks @SholomAber! This is very useful!

@josh-i386g
Copy link
Copy Markdown

Hi, are there cli flags to automate this?

--remove for Remove existing files and continue
--ignore for Ignore files and continue

@patak-cat
Copy link
Copy Markdown
Member

@josh-i386g, no, there isn't a way to do so. I think you should open a new feature request with more context about your use case. Your comment here will be quickly lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow initializing non-empty directory

5 participants