fix(create-vite): turn off react/jsx-no-target-blank ESLint rule in React JS template#15672
Merged
Conversation
|
|
ArnaudBarre
changed the title
react/jsx-no-target-blank ESLint rule in React JS templatereact/jsx-no-target-blank ESLint rule in React JS template
bluwy
approved these changes
Jan 22, 2024
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
Looks fine to me. I didn't know it was error-ing before. I'm curious why the TypeScript variant have a different eslint config setup though.
Member
Author
|
The goal was to provide a minimal setup to have ESLint running, and for TS the react plugin is not needed |
patak-cat
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses: #13750 (comment)
Changing it upstream has already been suggested: jsx-eslint/eslint-plugin-react#3552