You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a new ts file inside the src folder (for example newfile.ts) with this content: const MY_CONST = 1
Print the value of the constant inside App.tsx : {MY_CONST},
At this point, you should be able to compile (with npx tsc --noEmit) or build the app ( npm run build ) without errors, but the app fails at runtime ( npm run dev ) in the preview.
Notes:
I was only able to reproduce this with the react and react templates.
I think we should update it for the rest of the templates. It's not related to frameworks specifically. If you use MY_CONST in another .ts file for example, you can see that there's no errors either.
I think we should update it for the rest of the templates. It's not related to frameworks specifically. If you use MY_CONST in another .ts file for example, you can see that there's no errors either.
t-cc
changed the title
fix: update tsconfig in react and preact templates (fix: #17443)
fix: update tsconfig in new project templates (fix: #17443)
Jun 17, 2024
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bluwy
changed the title
fix: update tsconfig in new project templates (fix: #17443)
fix(create-vite): update tsconfig with moduleDetection true
Jun 18, 2024
bluwy
changed the title
fix(create-vite): update tsconfig with moduleDetection true
fix(create-vite): update tsconfig with moduleDetection force
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #17443
Problem solved:
With the current configuration, the application may compile successfully but fail at runtime.
Reproducible example here:https://stackblitz.com/edit/vitejs-vite-srbrdd
Reproduction
https://stackblitz.com/edit/vitejs-vite-srbrdd?file=tsconfig.json
Steps to reproduce
tsfile inside thesrcfolder (for examplenewfile.ts) with this content:const MY_CONST = 1App.tsx:{MY_CONST},At this point, you should be able to compile (with
npx tsc --noEmit) or build the app (npm run build) without errors, but the app fails at runtime (npm run dev) in the preview.Notes:
I was only able to reproduce this with the react and react templates.