refactor(create-vite): use named imports for react#17773
Merged
Conversation
|
|
ArnaudBarre
requested changes
Jul 27, 2024
Member
ArnaudBarre
left a comment
There was a problem hiding this comment.
- I agree for using named export.
- The temporary variable is not needed
!is always better than usingas
ArnaudBarre
approved these changes
Jul 28, 2024
Contributor
|
Same should apply for typescript template for consistency right? |
Member
|
FWIW React is still adamant with publishing in CJS, so named imports doesn't help much with treeshaking as CJS is harder to analyze. They also mention that the internals are very intertwined, so even if treeshaking works, you're not reducing by much. |
Member
|
Yeah I know that why it was not an issue but I think this is good to follow how every other modules are imported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the default Vite templates for React, in order to utilize named imports from react-dom/client instead of importing the entire ReactDOM namespace.
The reasons for change were: