refactor(create-vite): use picocolors#18085
Merged
Merged
Conversation
|
|
sapphi-red
approved these changes
Sep 12, 2024
Member
sapphi-red
left a comment
sapphi-red
left a comment
There was a problem hiding this comment.
Actually kolorist is slightly smaller because of tree-shaking (kolorist is 749B and picocolors is 847B), but I think it's good to align with the vite core package.
Member
Author
|
Ah interesting. Yeah I was comparing the package size. Forgot that Vite bundles it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
picocolorsinstead ofkoloristas it's smaller and faster