chore: combine deps license with same text#18356
Merged
Merged
Conversation
|
|
patak-cat
reviewed
Oct 15, 2024
|
|
||
| License: MIT | ||
| By: Sindre Sorhus | ||
| Repository: chalk/strip-ansi |
Member
There was a problem hiding this comment.
Would it be worth collapsing these lines but only do it when the By is the same in all repositories to keep things simple? It seems there are several cases like this
License: MIT
By: Sindre Sorhus
Repositories: ..., sindresorhus/run-applescript, chalk/strip-ansi
Member
|
Nice! 👏🏼 |
patak-cat
reviewed
Oct 16, 2024
patak-cat
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This shrinks our license file a bit by combining those with the same license text. It's slightly easier to review when hiding whitespace changes.
Initially my idea was even radical by grouping per license type, but it's not very feasible at the end since every license has slightly different formatting and additional text. Extending the copyright lines was also finicky to handle.