chore: speed up typechecking#20131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading Ryan comment on this PR , I remembered that I often forget to set this which induce perf hit for no good reason. I did it for the
tsconfig.check.jsonlast year when optimizing the build perf, but not for other tsconfigs.I also enable noEmit by default, declaration and generation is done by tsdown.
I removed baseUrl from the playground that is not needed anymore and will be deprecated in TS 6.
I did not touch the plugin-legacy because it's in a bad state,
tscfails there (it's does not run in CI). The issue is that it import types from the vite workspace and typechecking re-run on a lot of files from core. IMO the legacy plugin should depend on a publish version of Vite (like every other plugins does) and not the workspace one.On my computer,
pnpm typecheckwent from 7.5s to 6.0s.