Skip to content

fix(create-vite): use shorter command name for run dev for each package manager#20821

Merged
sapphi-red merged 2 commits into
vitejs:mainfrom
sapphi-red:fix/create-vite-use-run-dev-for-non-yarn-pkgmgr
Sep 23, 2025
Merged

fix(create-vite): use shorter command name for run dev for each package manager#20821
sapphi-red merged 2 commits into
vitejs:mainfrom
sapphi-red:fix/create-vite-use-run-dev-for-non-yarn-pkgmgr

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

To align with

switch (pkgManager) {
case 'yarn':
doneMessage += '\n yarn'
doneMessage += '\n yarn dev'
break
default:
doneMessage += `\n ${pkgManager} install`
doneMessage += `\n ${pkgManager} run dev`
break
}

Also deno dev doesn't work.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: create-vite create-vite package labels Sep 23, 2025
@sapphi-red sapphi-red marked this pull request as ready for review September 23, 2025 03:45
@bluwy
Copy link
Copy Markdown
Member

bluwy commented Sep 23, 2025

Shouldn't we try to fix it so that it shows pnpm dev too? Also for deno it's deno task dev

@sapphi-red sapphi-red changed the title fix(create-vite): use run dev for package managers other than yarn fix(create-vite): use shorter command name for run dev for each package manager Sep 23, 2025
@sapphi-red
Copy link
Copy Markdown
Member Author

I've updated the code to use the most popular commands for each pms.

Copy link
Copy Markdown
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sapphi-red sapphi-red merged commit 0c1bc8a into vitejs:main Sep 23, 2025
16 checks passed
@sapphi-red sapphi-red deleted the fix/create-vite-use-run-dev-for-non-yarn-pkgmgr branch September 23, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: create-vite create-vite package p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants