Skip to content

fix(create-vite): use reset for prompts for white bg color shell#6131

Merged
patak-cat merged 1 commit into
vitejs:mainfrom
userquin:fix/vite-cli-white-shell
Jan 17, 2022
Merged

fix(create-vite): use reset for prompts for white bg color shell#6131
patak-cat merged 1 commit into
vitejs:mainfrom
userquin:fix/vite-cli-white-shell

Conversation

@userquin
Copy link
Copy Markdown
Contributor

closes #6130

@userquin
Copy link
Copy Markdown
Contributor Author

userquin commented Dec 15, 2021

The result for white:

imagen

and on black:

imagen

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Dec 16, 2021
@userquin
Copy link
Copy Markdown
Contributor Author

userquin commented Dec 16, 2021

don't merge yet, I'm adding a feature request to prompts and maybe a PR.

EDIT: terkelg/prompts#345

@userquin
Copy link
Copy Markdown
Contributor Author

PR sent: terkelg/prompts#346

@userquin userquin marked this pull request as draft December 16, 2021 17:48
@userquin
Copy link
Copy Markdown
Contributor Author

Closing this, my PR merged on prompts repo, when released just update dep here.

@userquin userquin closed this Dec 21, 2021
@userquin userquin deleted the fix/vite-cli-white-shell branch December 21, 2021 00:55
@userquin
Copy link
Copy Markdown
Contributor Author

Upps, wrong PR, reverting...

@userquin userquin restored the fix/vite-cli-white-shell branch December 21, 2021 00:58
@userquin userquin reopened this Dec 21, 2021
@userquin userquin marked this pull request as ready for review January 17, 2022 18:42
@userquin
Copy link
Copy Markdown
Contributor Author

I think this can be merged.

@patak-cat patak-cat merged commit dd3bbb8 into vitejs:main Jan 17, 2022
@userquin userquin deleted the fix/vite-cli-white-shell branch January 17, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing entries when using create-vite on shell with white gbcolor

3 participants