chore: ensure local package private#6785
Merged
Merged
Conversation
antfu
approved these changes
Feb 7, 2022
jeffydc
approved these changes
Feb 7, 2022
patak-cat
approved these changes
Feb 7, 2022
Member
patak-cat
left a comment
There was a problem hiding this comment.
@bluwy LGTM, as the package.json is regenerated in create_vite. The templates are also used as is in StackBlitz, and there the private: true may not be the best as the user will need to remove it later but this is safer on Vite's side.
Member
Author
|
👍 I think it will be safer for the user too so they don't accidentally publish their project to npm, even if it's with lib mode. In the past when setting up changesets, the default template without |
Member
|
You are right. We should add |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure local packages have
"private": trueto prevent accidental publish. Also set forcreate-vitetemplates.Additional context
There are two
package.jsoninpackages/vite/src/node/__tests__/packagesthat I didn't update since it could affect the tests, but thepackage.jsonthemselves are already invalid so it prevents publishing.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).