chore: various cleanups (#797)

* chore: various cleanups

* chore: ignore no-unsafe-optional-chaining for now

Author: paescuj

.gitignore

@@ -1,6 +1,5 @@
 node_modules/
 dist/
 eslint-remote-tester-results/
-fixtures/node_modules
 .idea/
 .vscode/

.npmignore

@@ -4,7 +4,9 @@ import {
   getPathIgnorePattern,
   getRepositories,
 } from 'eslint-remote-tester-repositories'
-import vitest from './dist/index.mjs'
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+// @ts-ignore available once package is built
+import vitest from '@vitest/eslint-plugin'
 
 export default {
   repositories: getRepositories(),

README.md

@@ -1,28 +1,29 @@
+import eslint from '@eslint/js'
 import { defineConfig } from 'eslint/config'
+import tseslint from 'typescript-eslint'
+import gitignore from 'eslint-config-flat-gitignore'
 import vitest from './src/index.js'
 import eslintPlugin from 'eslint-plugin-eslint-plugin'
 import eslintConfigPrettier from 'eslint-config-prettier/flat'
-import tseslint from 'typescript-eslint'
 
 export default defineConfig(
-  eslintPlugin.configs.recommended,
-  vitest.configs.recommended,
+  gitignore(),
+  eslint.configs.recommended,
   tseslint.configs.recommended,
-  eslintConfigPrettier,
+  // @ts-expect-error see https://github.com/vitest-dev/eslint-plugin-vitest/issues/771
+  vitest.configs.recommended,
+  eslintPlugin.configs.recommended,
   {
     languageOptions: {
       parserOptions: {
         projectService: {
-          allowDefaultProject: [
-            'eslint.config.ts',
-            '.eslint-doc-generatorrc.js',
-            'vitest.config.mts',
-            'unbuild.config.ts',
-            'eslint-remote-tester.config.ts',
-            'scripts/chain-permutations.ts',
-          ],
+          allowDefaultProject: ['*.js'],
         },
-        tsconfigRootDir: import.meta.dirname,
+      },
+    },
+    settings: {
+      vitest: {
+        typecheck: true,
       },
     },
     rules: {
@@ -37,28 +38,9 @@ export default defineConfig(
       'eslint-plugin/require-meta-default-options': 'warn',
       'eslint-plugin/require-meta-schema-description': 'warn',
       'eslint-plugin/no-meta-schema-default': 'warn',
+      'no-prototype-builtins': 'warn',
+      'no-unsafe-optional-chaining': 'warn',
     },
   },
-  {
-    files: ['**/*.test.*'],
-    plugins: {
-      vitest,
-    },
-    rules: {
-      'eslint-plugin/require-meta-docs-description': 'error',
-    },
-    settings: {
-      vitest: {
-        typecheck: true,
-      },
-    },
-  },
-  {
-    ignores: ['**/dist/**'],
-  },
-  {
-    linterOptions: {
-      reportUnusedDisableDirectives: 'error',
-    },
-  },
+  eslintConfigPrettier,
 )

eslint-remote-tester.config.ts

@@ -2,15 +2,15 @@
   "name": "@vitest/eslint-plugin",
   "version": "1.3.23",
   "license": "MIT",
-  "description": "Eslint plugin for vitest",
+  "description": "ESLint plugin for Vitest",
   "repository": "vitest-dev/eslint-plugin-vitest",
   "keywords": [
     "eslint",
     "eslintplugin",
     "eslint-plugin",
-    "vitest eslint plugin",
+    "eslint plugin",
     "vitest",
-    "eslint plugin"
+    "vitest eslint plugin"
   ],
   "author": "Verite Mugabo <https://veritemugabo.com/>",
   "type": "module",
@@ -30,26 +30,29 @@
   "scripts": {
     "build": "tsdown --format esm --format cjs",
     "typecheck": "tsc --noEmit",
+    "lint": "concurrently --prefixColors auto \"pnpm:lint:*\"",
     "lint:eslint-docs": "pnpm build && eslint-doc-generator --check",
     "lint:js": "eslint",
-    "lint": "concurrently --prefixColors auto \"pnpm:lint:*\"",
-    "release": "bumpp package.json --commit --push --tag && pnpm build && pnpm publish",
-    "stub": "unbuild --stub",
+    "release": "bumpp && pnpm build && pnpm publish",
     "format": "prettier 'src/**/*.{ts,js}' --check",
     "test": "vitest",
+    "update:chains": "node scripts/chain-permutations.ts",
     "update:eslint-docs": "pnpm build && eslint-doc-generator"
   },
   "dependencies": {
     "@typescript-eslint/scope-manager": "^8.46.1",
     "@typescript-eslint/utils": "^8.46.1"
   },
   "devDependencies": {
+    "@eslint/js": "^9.38.0",
     "@types/eslint": "^9.6.1",
     "@types/node": "^22.18.10",
+    "@typescript-eslint/parser": "^8.46.1",
     "@typescript-eslint/rule-tester": "^8.46.1",
     "bumpp": "^10.3.1",
     "concurrently": "^9.2.1",
     "eslint": "^9.37.0",
+    "eslint-config-flat-gitignore": "^2.1.0",
     "eslint-config-prettier": "^10.1.8",
     "eslint-doc-generator": "^2.3.0",
     "eslint-plugin-eslint-plugin": "^7.0.0",
@@ -64,8 +67,8 @@
     "vitest": "^3.2.4"
   },
   "peerDependencies": {
-    "eslint": ">= 8.57.0",
-    "typescript": ">= 5.0.0",
+    "eslint": ">=8.57.0",
+    "typescript": ">=5.0.0",
     "vitest": "*"
   },
   "peerDependenciesMeta": {

eslint.config.ts

@@ -1,3 +1,4 @@
+savePrefix: ^
 injectWorkspacePackages: true
 onlyBuiltDependencies:
   - esbuild

package.json

@@ -1,8 +1,12 @@
-// imported from https://github.com/veritem/eslint-plugin-vitest/pull/293
-// This script generates all possible permutations for vitest methods
+/*
+ * This script generates all possible permutations for Vitest methods.
+ *
+ * Run it with `pnpm update:chains`.
+ *
+ * Originally imported from https://github.com/veritem/eslint-plugin-vitest/pull/293.
+ */
 import fs from 'node:fs'
 import path from 'node:path'
-import { per } from 'percom'
 
 const data = [
   {
@@ -114,7 +118,7 @@ data.forEach((q) => {
   })
 })
 
-const extra_rules = [
+const extraRules = [
   'xtest',
   'xtest.each',
   'xit',
@@ -125,18 +129,49 @@ const extra_rules = [
   'fdescribe',
 ]
 
-const output = `export const ValidVitestFnCallChains = new Set([${allPermutations.concat(extra_rules).map((item) => `'${item}'`)}])`
+const output = `export const ValidVitestFnCallChains = new Set([${allPermutations.concat(extraRules).map((item) => `'${item}'`)}])`
 
-const new_path = path.resolve(
-  __dirname,
+const newPath = path.resolve(
+  import.meta.dirname,
   '../src/utils/valid-vitest-fn-call-chains.ts',
 )
 
-try {
-  fs.writeFileSync(new_path, output)
-  console.log(
-    `done writing to ${new_path.split('/')[new_path.split('/').length - 1]}`,
-  )
-} catch (err) {
-  console.log(`err: ${err.message}`)
+fs.writeFileSync(newPath, output)
+console.log(
+  `done writing to ${newPath.split('/')[newPath.split('/').length - 1]}`,
+)
+
+// Based on https://github.com/kota-yata/Percom/blob/master/src/permutation.js (MIT licensed)
+function calcPer<T>(
+  array: T[],
+  num: number,
+  current: T[] = [],
+  result: T[][] = [],
+) {
+  if (current.length >= num) return null
+  let tempCurrent = current.slice(0, current.length)
+  for (let i = 0; i < array.length; i++) {
+    tempCurrent.push(array[i])
+    const slicedArray = array.filter((_, index) => index !== i)
+    const returned = calcPer(slicedArray, num, tempCurrent, result)
+    if (returned === null) result.push(tempCurrent)
+    tempCurrent = current.slice(0, current.length)
+  }
+  return result
+}
+/**
+ * Permutation
+ * @param array - Target array
+ * @param num - Number of elements in a permutation
+ * @return Return all permutations
+ * @example
+ * const result = per([1, 2, 3], 2);
+ * //result = [ [ 1, 2 ], [ 1, 3 ], [ 2, 1 ], [ 2, 3 ], [ 3, 1 ], [ 3, 2 ] ]
+ */
+function per<T>(array: T[], num: number) {
+  if (array.length < num)
+    throw new Error(
+      'Number of elements of array must be greater than number to choose',
+    )
+  return calcPer(array, num) as T[][]
 }