chore: split collect and filter slow tests logic

Author: userquin

packages/ui/client/composables/explorer/collector.ts

@@ -405,7 +405,7 @@ function collectTests(file: File, search: SearchMatcher = () => true, filter?: F
   } satisfies CollectFilteredTests
 
   for (const t of testsCollector(file)) {
-    if (!filter || testMatcher(t, search, filter)) {
+    if (!filter || testMatcher(t, search, filter, false)) {
       data.total++
       if (isSlowTestTask(t)) {
         data.slow++

packages/ui/client/composables/explorer/filter.ts

@@ -1,5 +1,6 @@
 import type { Task } from '@vitest/runner'
 import type { FileTreeNode, Filter, FilterResult, ParentTreeNode, SearchMatcher, UITaskTreeNode } from '~/composables/explorer/types'
+import { isTestCase } from '@vitest/runner/utils'
 import { client, config, findById } from '~/composables/client'
 import { explorerTree } from '~/composables/explorer/index'
 import { currentProjectName, filteredFiles, projectSort, uiEntries } from '~/composables/explorer/state'
@@ -10,8 +11,8 @@ import {
   isTestNode,
 } from '~/composables/explorer/utils'
 
-export function testMatcher(task: Task, search: SearchMatcher, filter: Filter) {
-  return task ? matchTask(task, search, filter) : false
+export function testMatcher(task: Task, search: SearchMatcher, filter: Filter, filterSlow = true) {
+  return task ? matchTask(task, search, filter, filterSlow) : false
 }
 /**
  * Filter child nodes using search, filter and only tests.
@@ -219,13 +220,11 @@ function* filterParents(
   }
 }
 
-function matchState(task: Task, filter: Filter) {
-  if (filter.slow) {
-    if (task.type === 'test') {
+function matchState(task: Task, filter: Filter, filterSlow = true) {
+  if (filterSlow && filter.slow) {
+    if (isTestCase(task)) {
       const threshold = config.value.slowTestThreshold
-      if (typeof threshold === 'number' && typeof task.result?.duration === 'number' && task.result.duration > threshold) {
-        return true
-      }
+      return typeof threshold === 'number' && typeof task.result?.duration === 'number' && task.result.duration > threshold
     }
   }
 
@@ -251,10 +250,11 @@ function matchTask(
   task: Task,
   search: SearchMatcher,
   filter: Filter,
+  filterSlow = true,
 ) {
   // search and filter will apply together
   if (search(task)) {
-    const hasStatusFilter = filter.success || filter.failed || filter.skipped || filter.slow
+    const hasStatusFilter = filter.success || filter.failed || filter.skipped || (filterSlow && filter.slow)
     if (hasStatusFilter) {
       if (matchState(task, filter)) {
         return true

packages/ui/client/composables/explorer/utils.ts

@@ -34,7 +34,7 @@ export function isParentNode(node: UITaskTreeNode): node is FileTreeNode | Suite
 }
 
 export function isSlowTestTask(task: Task) {
-  if (task.type !== 'test') {
+  if (!isTestCase(task)) {
     return false
   }
 
@@ -43,8 +43,8 @@ export function isSlowTestTask(task: Task) {
     return false
   }
 
-  const treshold = config.value.slowTestThreshold
-  return typeof treshold === 'number' && duration > treshold
+  const threshold = config.value.slowTestThreshold
+  return typeof threshold === 'number' && duration > threshold
 }
 
 export function getSortedRootTasks(sort: SortUIType, tasks = explorerTree.root.tasks) {