[WIP][Model Runner V2] Flash rejection sampling #132199
TheEpicDolphinpre-commit.yml
on: pull_request
pre-run-check
3s
pre-commit
4m 21s
Annotations
10 errors and 1 warning
|
pre-commit:
vllm/v1/worker/gpu/model_runner.py#L960
Argument 4 to "flash_sample" of "RejectionSampler" has incompatible type "Any | None"; expected "FlashSamplingConfig" [arg-type]
|
|
pre-commit:
vllm/v1/worker/gpu/model_runner.py#L950
Argument 3 to "flash_sample" of "Sampler" has incompatible type "Any | None"; expected "FlashSamplingConfig" [arg-type]
|
|
pre-commit:
vllm/v1/worker/gpu/model_runner.py#L947
Item "None" of "Sampler | None" has no attribute "flash_sample" [union-attr]
|
|
pre-commit:
vllm/v1/worker/gpu/model_runner.py#L854
Too many arguments for "combine_sampled_and_draft_tokens" [call-arg]
|
|
pre-commit:
vllm/v1/worker/gpu/spec_decode/eagle/speculator.py#L261
Item "None" of "Any | None" has no attribute "shard_indices" [union-attr]
|
|
pre-commit:
vllm/v1/worker/gpu/spec_decode/eagle/speculator.py#L260
Item "None" of "Any | None" has no attribute "lm_head_weight" [union-attr]
|
|
pre-commit:
vllm/v1/worker/gpu/spec_decode/rejection_sampler.py#L194
Value of type "Any | None" is not indexable [index]
|
|
Ruff (E501):
vllm/v1/worker/gpu/spec_decode/flash_rejection_sampler_utils.py#L176
vllm/v1/worker/gpu/spec_decode/flash_rejection_sampler_utils.py:176:89: E501 Line too long (89 > 88)
|
|
Ruff (E501):
vllm/v1/worker/gpu/spec_decode/flash_rejection_sampler_utils.py#L132
vllm/v1/worker/gpu/spec_decode/flash_rejection_sampler_utils.py:132:89: E501 Line too long (89 > 88)
|
|
Ruff (E501):
vllm/v1/worker/gpu/model_runner.py#L938
vllm/v1/worker/gpu/model_runner.py:938:89: E501 Line too long (89 > 88)
|
|
pre-commit
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|