Skip to content

Commit 5bcc50b

Browse files
committed
Add comments to variable definitions
Review comments: - #41727 (comment) - #41727 (comment) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
1 parent 6bea04b commit 5bcc50b

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

vllm/v1/kv_offload/cpu/manager.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ def __init__(
5555
self._policy: CachePolicy = policy_cls(cache_capacity=num_blocks)
5656
self.store_threshold: int = store_threshold
5757
self.max_tracker_size: int = max_tracker_size
58+
59+
# Number of block references. It is ordered so can evict the LRU entry in O(1).
5860
self.counts: OrderedDict[OffloadKey, int] | None = (
5961
OrderedDict() if store_threshold >= 2 else None
6062
)

vllm/v1/kv_offload/cpu/spec.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,15 @@ def get_manager(self) -> OffloadingManager:
5959
enable_events = (
6060
kv_events_config is not None and kv_events_config.enable_kv_cache_events
6161
)
62+
63+
# store_threshold: how many times a block must appear in lookup()
64+
# before it is eligible for CPU offloading. Values < 2 disable
65+
# filtering (a threshold of 1 equals no filter; 0 is the default).
6266
store_threshold = int(self.extra_config.get("store_threshold", 0))
67+
68+
# Maximum entries in the internal tracker's LRU table.
6369
max_tracker_size = int(self.extra_config.get("max_tracker_size", 64_000))
70+
6471
self._manager = CPUOffloadingManager(
6572
num_blocks=self.num_blocks,
6673
cache_policy=self.eviction_policy, # type: ignore[arg-type]

0 commit comments

Comments
 (0)