magento#16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes"

- refactor variable names.

Author: vpodorozh

app/code/Magento/ConfigurableProduct/Model/ResourceModel/Product/StockStatusBaseSelectProcessor.php

@@ -35,21 +35,21 @@ class StockStatusBaseSelectProcessor implements BaseSelectProcessorInterface
     /**
      * @var StockStatusConfigurableInterface
      */
-    private $stockStatusConfigurableResource;
+    private $stockConfigurable;
 
     /**
      * @param StockConfigurationInterface $stockConfig
      * @param StockStatusResource $stockStatusResource
-     * @param StockStatusConfigurableInterface $stockStatusConfigurableResource
+     * @param StockStatusConfigurableInterface $stockConfigurable
      */
     public function __construct(
         StockConfigurationInterface $stockConfig,
         StockStatusResource $stockStatusResource,
-        StockStatusConfigurableInterface $stockStatusConfigurableResource = null
+        StockStatusConfigurableInterface $stockConfigurable = null
     ) {
         $this->stockConfig = $stockConfig;
         $this->stockStatusResource = $stockStatusResource;
-        $this->stockStatusConfigurableResource = $stockStatusConfigurableResource ?:
+        $this->stockConfigurable = $stockConfigurable ?:
             ObjectManager::getInstance()->get(StockStatusConfigurableInterface::class);
     }
 
@@ -84,6 +84,6 @@ public function process(Select $select, int $productId): Select
      */
     private function isAllChildOutOfStock(int $productId): bool
     {
-        return $this->stockStatusConfigurableResource->isAllChildOutOfStock($productId);
+        return $this->stockConfigurable->isAllChildOutOfStock($productId);
     }
 }

app/code/Magento/ConfigurableProduct/Pricing/Render/FinalPriceBox.php

@@ -41,7 +41,7 @@ class FinalPriceBox extends \Magento\Catalog\Pricing\Render\FinalPriceBox
      * @param array $data
      * @param LowestPriceOptionsProviderInterface $lowestPriceOptionsProvider
      * @param SalableResolverInterface|null $salableResolver
-     * @param MinimalPriceCalculatorInterface|null $minimalPriceCalculator
+     * @param MinimalPriceCalculatorInterface|null $minPriceCalculator
      * @param StockStatus $stockStatus
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
@@ -54,7 +54,7 @@ public function __construct(
         array $data = [],
         LowestPriceOptionsProviderInterface $lowestPriceOptionsProvider = null,
         SalableResolverInterface $salableResolver = null,
-        MinimalPriceCalculatorInterface $minimalPriceCalculator = null,
+        MinimalPriceCalculatorInterface $minPriceCalculator = null,
         StockStatus $stockStatus = null
     ) {
         parent::__construct(
@@ -64,7 +64,7 @@ public function __construct(
             $rendererPool,
             $data,
             $salableResolver,
-            $minimalPriceCalculator
+            $minPriceCalculator
         );
         $this->lowestPriceOptionsProvider = $lowestPriceOptionsProvider ?:
             ObjectManager::getInstance()->get(LowestPriceOptionsProviderInterface::class);