feat: add type-level readonly() api
#593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikax
reviewed
Nov 23, 2020
| * Creates a readonly copy of the original object. Note the returned copy is not | ||
| * made reactive, but `readonly` can be called on an already reactive object. | ||
| */ | ||
| export function readonly<T extends object>( |
Member
There was a problem hiding this comment.
Not sure if is worth to have readonly if it's the same as shallowReadonly
Member
Author
There was a problem hiding this comment.
It's for the API alignment with Vue 3, lowing the difference between them. Thinking import { readonly } from 'vue-demi will work for Vue 3 but failed on Vue 2. This implementation acts like a noop but providing the type-level checking as the same as Vue 3. Should be good enough for users using TypeScript.
antfu
commented
Nov 25, 2020
pikax
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.