Skip to content

Conversation

@antfu
Copy link
Member

@antfu antfu commented Nov 22, 2020

No description provided.

@jacekkarczmarczyk
Copy link
Contributor

shouldn't slots, listeners and refs be using [keyin string]?: type?

With [key: string] for example slots.foo is always defined, but imho user should actually check if there's a slot with provided name

https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgGIHt3IN4ChnIDaA1hAJ4BcyAzmFKAOYC6Vt9IDuAvrrmGQAcUAIThRkAXhz4ipMslA06jJgH5Wyjt14wAriARhg6EMki1kAChiYqGdABpkAIzFVRUAJTSCCE9XQAGwgAOkD0BmtMEJhgAC84510EsIgOMAALJ1coGPjE5LjU9IzPbSA

image

@antfu
Copy link
Member Author

antfu commented Nov 22, 2020

Agree. Fixed, thanks!

@antfu antfu merged commit 49766bf into vuejs:master Nov 23, 2020
@antfu antfu deleted the fix/setup-context-types branch November 23, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants