chore: improve code

rudyxu1102 · rudyxu1102 · commit 202922b1ae23 · 2023-02-23T20:00:19.000+08:00
diff --git a/packages/runtime-core/__tests__/apiWatch.spec.ts b/packages/runtime-core/__tests__/apiWatch.spec.ts
@@ -553,7 +553,7 @@ describe('api: watch', () => {
   // #7030
   it('should not fire on child component unmount w/ flush: pre', async () => {
     const visible = ref(true)
-    const cb = jest.fn()
+    const cb = vi.fn()
     const Parent = defineComponent({
       props: ['visible'],
       render() {
diff --git a/packages/runtime-core/src/scheduler.ts b/packages/runtime-core/src/scheduler.ts
@@ -145,10 +145,10 @@ export function flushPreFlushCbs(
   for (; i < queue.length; i++) {
     const cb = queue[i]
     if (cb && cb.pre) {
-      if (__DEV__ && checkRecursiveUpdates(seen!, cb)) {
+      if (instance && cb.id !== instance.uid) {
         continue
       }
-      if (instance && cb.id !== instance.uid) {
+      if (__DEV__ && checkRecursiveUpdates(seen!, cb)) {
         continue
       }
       queue.splice(i, 1)

Original file line number	Diff line number	Diff line change
`@@ -145,10 +145,10 @@ export function flushPreFlushCbs(`
`145`	`145`	`for (; i < queue.length; i++) {`
`146`	`146`	`const cb = queue[i]`
`147`	`147`	`if (cb && cb.pre) {`
`148`		`- if (__DEV__ && checkRecursiveUpdates(seen!, cb)) {`
	`148`	`+ if (instance && cb.id !== instance.uid) {`
`149`	`149`	`continue`
`150`	`150`	`}`
`151`		`- if (instance && cb.id !== instance.uid) {`
	`151`	`+ if (__DEV__ && checkRecursiveUpdates(seen!, cb)) {`
`152`	`152`	`continue`
`153`	`153`	`}`
`154`	`154`	`queue.splice(i, 1)`