improve code

improve code

improve code

Author: edison1105

packages/reactivity/src/effectScope.ts

@@ -76,8 +76,14 @@ export class EffectScope {
 
   stop(fromParent?: boolean) {
     if (this.active) {
-      this.effects.forEach(e => e.stop())
       let i, l
+      // #5783
+      // effects maybe changed when an effect stoped.
+      // so we need to copy it for iteration.
+      const effectsToStop = this.effects.slice()
+      for (i = 0, l = effectsToStop.length; i < l; i++) {
+        effectsToStop[i].stop()
+      }
       for (i = 0, l = this.cleanups.length; i < l; i++) {
         this.cleanups[i]()
       }