fix(runtime-core): ensure app instance can be garbage collected after unmount (close #2907) (#2909)

LinusBorg · Thorsten Luenborg · web-flow · commit 60e05eff232c · 2021-02-03T19:09:20.000+01:00
close #2907 Co-authored-by: Thorsten Luenborg <t.luneborg@googlemail.com>
diff --git a/packages/runtime-core/src/apiCreateApp.ts b/packages/runtime-core/src/apiCreateApp.ts
@@ -272,6 +272,7 @@ export function createAppAPI<HostElement>(
           if (__DEV__ || __FEATURE_PROD_DEVTOOLS__) {
             devtoolsUnmountApp(app)
           }
+          delete app._container.__vue_app__
         } else if (__DEV__) {
           warn(`Cannot unmount an app that is not mounted.`)
         }

Original file line number	Diff line number	Diff line change
`@@ -272,6 +272,7 @@ export function createAppAPI<HostElement>(`
`272`	`272`	`if (__DEV__ \|\| __FEATURE_PROD_DEVTOOLS__) {`
`273`	`273`	`devtoolsUnmountApp(app)`
`274`	`274`	`}`
	`275`	`+ delete app._container.__vue_app__`
`275`	`276`	`} else if (__DEV__) {`
`276`	`277`	warn(`Cannot unmount an app that is not mounted.`)
`277`	`278`	`}`