feat(compiler-core): support Symbol in template#9069
Merged
Conversation
Size ReportBundles
Usages
|
sxzz
reviewed
Aug 29, 2023
Member
|
I think our goal is not to make it as comprehensive as possible, but sufficient to meet actual needs. I don't think there are actual use cases for most of the added globals here. |
sxzz
previously approved these changes
Aug 31, 2023
sxzz
changed the title
sxzz
reviewed
Sep 5, 2023
added 2 commits
September 6, 2023 13:15
… commit removes obsolete global variables from the globalsAllowList.ts file to simplify and optimize the code
sxzz
reviewed
Sep 6, 2023
…ects and functions
sxzz
approved these changes
Sep 6, 2023
sxzz
changed the title
Member
|
merge PR #7018 first. |
sxzz
changed the title
sxzz
requested changes
Oct 20, 2023
sxzz
left a comment
sxzz
left a comment
Member
There was a problem hiding this comment.
A unit test is needed in packages/compiler-core/__tests__/transforms/transformExpressions.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relate #9027