From e291146093b91e8d36d339a8e8993e5aa1d5df29 Mon Sep 17 00:00:00 2001 From: likui <2218301630@qq.com> Date: Wed, 3 Jun 2020 16:30:21 +0800 Subject: [PATCH] fix: should can re-mount after unmount fix #1287 --- packages/runtime-core/__tests__/apiCreateApp.spec.ts | 3 +++ packages/runtime-core/src/apiCreateApp.ts | 1 + 2 files changed, 4 insertions(+) diff --git a/packages/runtime-core/__tests__/apiCreateApp.spec.ts b/packages/runtime-core/__tests__/apiCreateApp.spec.ts index fbc784f44d4..b6a622bf784 100644 --- a/packages/runtime-core/__tests__/apiCreateApp.spec.ts +++ b/packages/runtime-core/__tests__/apiCreateApp.spec.ts @@ -65,6 +65,9 @@ describe('api: createApp', () => { app.unmount(root) expect(serializeInner(root)).toBe(``) + // #1287 should can re-mount after unmount + app.mount(root) + expect(serializeInner(root)).toBe(`0`) }) test('provide', () => { diff --git a/packages/runtime-core/src/apiCreateApp.ts b/packages/runtime-core/src/apiCreateApp.ts index 4e3079e436f..00febf4c12c 100644 --- a/packages/runtime-core/src/apiCreateApp.ts +++ b/packages/runtime-core/src/apiCreateApp.ts @@ -233,6 +233,7 @@ export function createAppAPI( unmount() { if (isMounted) { render(null, app._container) + isMounted = false } else if (__DEV__) { warn(`Cannot unmount an app that is not mounted.`) }