Skip to content

Object in query string parameters does not trigger "route change" if its properties changes #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ppdeassis opened this issue Jun 14, 2017 · 2 comments

Comments

@ppdeassis
Copy link

Version

2.5.3

Reproduction link

http://jsfiddle.net/6znsr5wd/3/

Steps to reproduce

  1. Access fiddle and click on Access Home
  2. Enter any value on the input
  • it will be the object property used on query string
  1. Click on Update route button
  • it will replace the route, using the object on query string
  • the query string will be rendered in the <code> tag
  1. Change the value on the input and click on Update route again

What is expected?

The query string is updated with the new value on the object property.

What is actually happening?

The query string remains the same, ignoring the change on object's property.


After some digging in the code, I think I found the object comparison method used in confirmTransition method (which uses isSameRoute), and it does a simple "non-deep" comparison of properties on query string. Since it's using an Object on the query string, it should do a deep (recursive) comparison of Object properties.

@posva
Copy link
Member

posva commented Jun 15, 2017

dup of #1421
FYI, vue-router does not support nested queries by default, but you can use a lib like qs: http://jsfiddle.net/posva/y5boz2jf/1/
There's already a PR for this at #1425

@posva posva closed this as completed Jun 15, 2017
@ppdeassis ppdeassis changed the title Object in query string parameters do not trigger "route change" if its properties changes Object in query string parameters does not trigger "route change" if its properties changes Jun 15, 2017
@ppdeassis
Copy link
Author

Thanks, @posva.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants