-
Notifications
You must be signed in to change notification settings - Fork 668
Rename shallow to shallowMount #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I prefer It seems a lot of people are confused by |
Another potentially less confusing alternative could be a const wrapper = mount(Component, {
shallow: true
}) Although I don't have a strong opinion either way. |
Since VTU is about unit testing, and that more or less means one does not mount/test child components, what about I understand that perhaps people would complain "hey, my components do not get properly mounted" if they don't see child components mounted as well and didn't read the docs about shallow/non-shallow. Anyway, that is another idea that may or may not work. |
I think the |
My preference is to rename |
It's easy enough to set up an alias from for people who prefer |
As discussed with @eddyerburgh, I've had to explain to a lot of people that
shallow
does actually mount, it's just a shallow mount. 😄 This rename would make that clearer.The text was updated successfully, but these errors were encountered: