Skip to content

[Feature request] Last Update should be support to change date format pattern #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xkcoding opened this issue Jun 11, 2018 · 4 comments
Closed
Labels
type: feature request Request to add a new feature version: next Planned to do or already included in the next(1.0.0) version

Comments

@xkcoding
Copy link

xkcoding commented Jun 11, 2018

Feature request

What problem does this feature solve?

this feature can make last update more comfortable if it could support to change date format like 'YYYY-MM-DD hh:mm:ss'

What does the proposed API look like?

API will be based on https://vuepress.vuejs.org/default-theme-config/#last-updated
look like this:

module.exports = {
  themeConfig: {
    lastUpdated: {
        label: 'Last Updated', // string
        format: 'YYYY年MM月DD日 hh:mm:ss' // pattern can refer to moment.js
    }
  }
}

How should this be implemented in your opinion?

emmm... I think may be use moment.js or others...

Are you willing to work on this yourself?

emmm... I'm not good at javascript... but i will do some research... if I resolved by myself. I will push a PR~

sorry for my poor English...
thank you for your reading~

@xkcoding xkcoding changed the title [Feature request] Last Update support to change date format [Feature request] Last Update should be support to change date format pattern Jun 11, 2018
@ulivz
Copy link
Member

ulivz commented Jun 11, 2018

Good idea, and it has also been listed in my TODOs list.

But I have extracted it as a standalone plugin, so hold it and please wait us to finalize the plugin API.

@ulivz ulivz added plugin scope type: feature request Request to add a new feature labels Jun 11, 2018
@xkcoding
Copy link
Author

huh. expect your plugin

@meteorlxy
Copy link
Member

Suggest using date-fns/format

@daltondiaz
Copy link
Contributor

daltondiaz commented Jul 15, 2018

Yo @ulivz I don't understood what do you saying about standalone plugin and plugin API, can you explain only for me understand better? Thank you!

I found the issue where you describe the plugin API: #329

@ulivz ulivz added version: next Planned to do or already included in the next(1.0.0) version and removed plugin scope labels Aug 20, 2018
@vuejs vuejs deleted a comment from willin Sep 19, 2018
@vuejs vuejs deleted a comment from willin Sep 19, 2018
@vuejs vuejs deleted a comment from willin Sep 19, 2018
@vuejs vuejs locked and limited conversation to collaborators Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature request Request to add a new feature version: next Planned to do or already included in the next(1.0.0) version
Projects
None yet
Development

No branches or pull requests

4 participants