From 36696830a2c1cc3ebd21cc7aae94e3a6672ecc64 Mon Sep 17 00:00:00 2001 From: Anna Musial Date: Wed, 14 Jun 2023 15:38:35 +0200 Subject: [PATCH] fix: breaking change - sfbutton padding size (#2815) * chore: added changeset for button size * chore: added changeset --- .changeset/five-geese-serve.md | 6 ++++++ .../sfui/frameworks/react/components/SfButton/SfButton.tsx | 2 +- .../sfui/frameworks/vue/components/SfButton/SfButton.vue | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 .changeset/five-geese-serve.md diff --git a/.changeset/five-geese-serve.md b/.changeset/five-geese-serve.md new file mode 100644 index 0000000000..8cb149d8fc --- /dev/null +++ b/.changeset/five-geese-serve.md @@ -0,0 +1,6 @@ +--- +'@storefront-ui/react': major +'@storefront-ui/vue': major +--- + +Breaking Change - Padding size for square variant of SfButton changed diff --git a/packages/sfui/frameworks/react/components/SfButton/SfButton.tsx b/packages/sfui/frameworks/react/components/SfButton/SfButton.tsx index 92503048b5..179b2b2109 100644 --- a/packages/sfui/frameworks/react/components/SfButton/SfButton.tsx +++ b/packages/sfui/frameworks/react/components/SfButton/SfButton.tsx @@ -17,7 +17,7 @@ const getSizeClasses = (size: SfButtonProps['size'], square: SfButtonProps['squa case SfButtonSize.sm: return [square ? 'p-1.5' : 'leading-5 text-sm py-1.5 px-3', 'gap-1.5']; case SfButtonSize.lg: - return [square ? 'p-4' : 'py-3 leading-6 px-6', 'gap-3']; + return [square ? 'p-3' : 'py-3 leading-6 px-6', 'gap-3']; default: return [square ? 'p-2' : 'py-2 leading-6 px-4', 'gap-2']; } diff --git a/packages/sfui/frameworks/vue/components/SfButton/SfButton.vue b/packages/sfui/frameworks/vue/components/SfButton/SfButton.vue index 6cff5a0e95..759f0b1b6f 100644 --- a/packages/sfui/frameworks/vue/components/SfButton/SfButton.vue +++ b/packages/sfui/frameworks/vue/components/SfButton/SfButton.vue @@ -43,7 +43,7 @@ const sizeClasses = computed(() => { case SfButtonSize.sm: return [square.value ? 'p-1.5' : 'leading-5 text-sm py-1.5 px-3', 'gap-1.5']; case SfButtonSize.lg: - return [square.value ? 'p-4' : 'py-3 leading-6 px-6', 'gap-3']; + return [square.value ? 'p-3' : 'py-3 leading-6 px-6', 'gap-3']; default: return [square.value ? 'p-2' : 'py-2 leading-6 px-4', 'gap-2']; }