From 689a11ed3c85b4a0ca1e36a44399ec9d6cafc824 Mon Sep 17 00:00:00 2001 From: Anna Musial Date: Thu, 15 Jun 2023 09:50:46 +0200 Subject: [PATCH 1/4] fix: changed paddings in sfselect --- .changeset/fresh-emus-care.md | 6 ++++++ .../sfui/frameworks/react/components/SfSelect/SfSelect.tsx | 2 +- .../sfui/frameworks/vue/components/SfSelect/SfSelect.vue | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 .changeset/fresh-emus-care.md diff --git a/.changeset/fresh-emus-care.md b/.changeset/fresh-emus-care.md new file mode 100644 index 0000000000..703e17ffd5 --- /dev/null +++ b/.changeset/fresh-emus-care.md @@ -0,0 +1,6 @@ +--- +'@storefront-ui/react': major +'@storefront-ui/vue': major +--- + +Breaking Change - Padding right in SfSelect changed from 14px to 12px diff --git a/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx b/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx index 81d99d486b..6c5251378a 100644 --- a/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx +++ b/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx @@ -45,7 +45,7 @@ export default function SfSelect(props: SfSelectProps) { required={required} disabled={disabled} className={classNames( - 'appearance-none disabled:cursor-not-allowed cursor-pointer pl-4 pr-3.5 text-neutral-900 focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-inset ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200', + 'appearance-none disabled:cursor-not-allowed cursor-pointer pl-4 pr-3 text-neutral-900 focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-inset ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200', { 'py-1.5': size === SfSelectSize.sm, 'py-2': size === SfSelectSize.base, diff --git a/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue b/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue index f4165b1b05..b357f0545b 100644 --- a/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue +++ b/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue @@ -73,7 +73,7 @@ const changedValue = (event: Event) => { :required="required" :disabled="disabled" :class="[ - 'appearance-none disabled:cursor-not-allowed cursor-pointer pl-4 pr-3.5 text-neutral-900 ring-inset focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200', + 'appearance-none disabled:cursor-not-allowed cursor-pointer pl-4 pr-3 text-neutral-900 ring-inset focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200', { 'py-1.5': size === SfSelectSize.sm, 'py-2': size === SfSelectSize.base, From 835ebe218e85ae44829d851cd045b4658fe37e39 Mon Sep 17 00:00:00 2001 From: Anna Musial Date: Mon, 26 Jun 2023 10:03:09 +0200 Subject: [PATCH 2/4] chore: adjusted padding left --- packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx | 2 +- packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx b/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx index 6c5251378a..55266cc709 100644 --- a/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx +++ b/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx @@ -45,7 +45,7 @@ export default function SfSelect(props: SfSelectProps) { required={required} disabled={disabled} className={classNames( - 'appearance-none disabled:cursor-not-allowed cursor-pointer pl-4 pr-3 text-neutral-900 focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-inset ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200', + 'appearance-none disabled:cursor-not-allowed cursor-pointer px-3 text-neutral-900 focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-inset ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200', { 'py-1.5': size === SfSelectSize.sm, 'py-2': size === SfSelectSize.base, diff --git a/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue b/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue index b357f0545b..09a724dedd 100644 --- a/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue +++ b/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue @@ -73,7 +73,7 @@ const changedValue = (event: Event) => { :required="required" :disabled="disabled" :class="[ - 'appearance-none disabled:cursor-not-allowed cursor-pointer pl-4 pr-3 text-neutral-900 ring-inset focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200', + 'appearance-none disabled:cursor-not-allowed cursor-pointer px-3 text-neutral-900 ring-inset focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200', { 'py-1.5': size === SfSelectSize.sm, 'py-2': size === SfSelectSize.base, From 148a54273ff58c8daee5dd280083a4a285b52f34 Mon Sep 17 00:00:00 2001 From: Anna Musial Date: Mon, 26 Jun 2023 10:08:12 +0200 Subject: [PATCH 3/4] chore: updated changelog --- .changeset/fresh-emus-care.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/fresh-emus-care.md b/.changeset/fresh-emus-care.md index 703e17ffd5..d87226313d 100644 --- a/.changeset/fresh-emus-care.md +++ b/.changeset/fresh-emus-care.md @@ -3,4 +3,4 @@ '@storefront-ui/vue': major --- -Breaking Change - Padding right in SfSelect changed from 14px to 12px +Breaking Change - Padding left adn rigth in SfSelect changed from 14px and 16px to 12px From b55a4d313266356a24fd241b1bd7b1ae53451916 Mon Sep 17 00:00:00 2001 From: Anna Musial Date: Wed, 28 Jun 2023 13:05:49 +0200 Subject: [PATCH 4/4] Update .changeset/fresh-emus-care.md Co-authored-by: Jakub Freisler --- .changeset/fresh-emus-care.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/fresh-emus-care.md b/.changeset/fresh-emus-care.md index d87226313d..277858e08b 100644 --- a/.changeset/fresh-emus-care.md +++ b/.changeset/fresh-emus-care.md @@ -3,4 +3,4 @@ '@storefront-ui/vue': major --- -Breaking Change - Padding left adn rigth in SfSelect changed from 14px and 16px to 12px +Breaking Change - Padding left and right in SfSelect changed from 14px and 16px to 12px