Skip to content

Commit 50eac1d

Browse files
authored
Merge pull request #2 from DivanteLtd/develop
Develop
2 parents 39adb69 + 599b7c4 commit 50eac1d

File tree

3 files changed

+11
-14
lines changed

3 files changed

+11
-14
lines changed

CHANGELOG.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1515
- Added `syncTasks` cleanup, `elasticCacheQuota` lowered to 3096KB - @pkarw (#2729)
1616
- Added back-button on orde detail page [#2819]
1717
- Added Elastic Search Suggestions in the Search Response - @jpetar (#2853)
18-
- npm packages with the prefix `vsf-` will be processed by webpack during build, this also works for scoped packages i.e. `@example/vsf-` - @zimme (#2271, #2395)
1918
- Added back to top functionality - @vishal-7037 (#2866)
2019

2120
### Fixed
@@ -107,7 +106,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
107106
- Offline orders with out of stock products don't stack anymore and get canceled after going back to online - @lukeromanowicz (#2740)
108107
- Build ServiceWorker on Docker - @patzick (#2793)
109108
- Product image load after comming back to online - @patzick (#2573)
110-
- Insufficent validation for city field in checkout address - @lromanowicz (#2653)
109+
- Insufficent validation for city field in checkout address - @lromanowicz (#2653)
111110
- Incorrect hover activity on the 'filter by categories' in the search view on mobile - @idodidodi (#2783)
112111
- Unit tests written in JavaScript now support async/await functions and dynamic import - @michaelKurowski, @lukeromanowicz (#2851)
113112

core/build/webpack.base.config.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export default {
125125
enforce: 'pre',
126126
test: /\.(js|vue)$/,
127127
loader: 'eslint-loader',
128-
exclude: [/node_modules(?!\/(\@.*\/)?vsf-)/, /test/]
128+
exclude: [/node_modules/, /test/]
129129
},
130130
{
131131
test: /\.vue$/,
@@ -139,19 +139,17 @@ export default {
139139
test: /\.ts$/,
140140
loader: 'ts-loader',
141141
options: {
142-
appendTsSuffixTo: [/\.vue$/],
143-
allowTsInNodeModules: true
142+
appendTsSuffixTo: [/\.vue$/]
144143
},
145-
exclude: /node_modules(?!\/(\@.*\/)?vsf-)/
144+
exclude: /node_modules/
146145
},
147146
{
148147
test: /\.js$/,
149148
loader: 'babel-loader',
150149
include: [
151150
path.resolve(__dirname, '../../node_modules/@vue-storefront'),
152151
path.resolve(__dirname, '../../src'),
153-
path.resolve(__dirname, '../../core'),
154-
/node_modules\/(\@.*\/)?vsf-.*/
152+
path.resolve(__dirname, '../../core')
155153
]
156154
},
157155
{
@@ -198,7 +196,7 @@ export default {
198196
},
199197
{
200198
test: /\.(graphqls|gql)$/,
201-
exclude: /node_modules(?!\/(\@.*\/)?vsf-)/,
199+
exclude: /node_modules/,
202200
loader: ['graphql-tag/loader']
203201
}
204202
]

docs/guide/modules/introduction.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
- [Adding new features as VS modules](#adding-new-features-as-vs-modules)
1717
- [Extending and overriding Vue Storefront modules](#extending-and-overriding-vue-storefront-modules)
1818
- [Creating third party modules](#Creating-3rd-party-modules)
19-
19+
2020
# What are VS modules?
2121

22-
You can think about each module as a one, independent feature available in Vue Storefront with all it's logic and dependencys inside. This 'one feature' however is a common denominator that links all the features inside. For example common denominator for adding product to the cart, receiving list of items that are in a cart or applying a cart coupon is obviously a `cart` and `cart` is not a feature of anything bigger than itself (it's common denominator is a shop) so it should be a module. Wishlist, Reviews or Newsletter are also a good examples of modules as we intuitively think about them as a standalone features.
22+
You can think about each module as a one, independent feature available in Vue Storefront with all it's logic and dependencys inside. This 'one feature' however is a common denominator that links all the features inside. For example common denominator for adding product to the cart, receiving list of items that are in a cart or applying a cart coupon is obviously a `cart` and `cart` is not a feature of anything bigger than itself (it's common denominator is a shop) so it should be a module. Wishlist, Reviews or Newsletter are also a good examples of modules as we intuitively think about them as a standalone features.
2323

2424
# Motivation
2525

@@ -102,7 +102,7 @@ Entry point for vue-router. You can provide additional routes and [navigation gu
102102

103103
Function that'll be called before registering the module both on server and client side. You have access to VSF object here.
104104

105-
The `VSF` object is an instance of your Vue Storefront shop. It contains following properties
105+
The `VSF` object is an instance of your Vue Storefront shop. It contains following properties
106106
````js
107107
Vue?: VueConstructor,
108108
config?: Object,
@@ -113,7 +113,7 @@ The `VSF` object is an instance of your Vue Storefront shop. It contains followi
113113

114114
Function that'll be called after registering the module both on server and client side. You have access to VSF object here.
115115

116-
The `VSF` object is an instance of your Vue Storefront shop. It contains following properties
116+
The `VSF` object is an instance of your Vue Storefront shop. It contains following properties
117117
````js
118118
Vue?: VueConstructor,
119119
config?: Object,
@@ -277,7 +277,7 @@ export const registerModules: VueStorefrontModule[] = [Cart]
277277

278278
## Creating third party modules
279279

280-
If you want to create third party module just copy the `src/modules/module-template` raw code to your repo. Don't use any transpilation and build tools since it prevents proper tree shaking and optimization. Building is handled by Vue Storefront build tools. Package name needs to start with `vsf-` prefix to be included into Vue Storefront build process. Scoped package names also work i.e. `@example/vsf-`
280+
If you want to create third party module just copy the `src/modules/module-template` raw code to your repo. Don't use any transpilation and build tools since it prevents proper tree shaking and optimization. Building is handled by Vue Storefront build tools. Package name needs to start with `vsf-` prefix to be included into Vue Storefront build process.
281281

282282
## Contributions
283283

0 commit comments

Comments
 (0)