-
Notifications
You must be signed in to change notification settings - Fork 79
privacy considerations #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Platforms and tracing systems MUST NOT include any personal identifieable information into
tracestate
header.
I think OpenTracing should be noticed, the baggage
concepts will have some conflicts with the Privacy rules, if some supported tracers support both this spec and OT.
FYI @tedsuo
I added privacy note to make sure any service may store and propagate |
trace_context/compliance.md
Outdated
|
||
Requirements to propagate headers to downstream services opens a potential privacy concerns. The only way to remove this concern is to inspect and remove values from the fields values before allowing the platform or tracing system to execute code that potentially can propagate these headers. All mutations should, however, conform to the list of mutations defined in this specification. | ||
|
||
## Privacy of traceparent field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary a privacy concern, more like an usability concern is when the service initiating calls use the same trace-parent every time then this cause the service owner to not be able to distinguish between different calls. this my be solved by restarting the trace on the service side if the client is untrusted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'd start security section for this. This doc purpose was to ensure the traceparent
and tracestate
can be stored and transmitted without implications for privacy and things like GDPR.
👍 from my side. It would be a good idea to explicitly mention that there must be no storage restrictions on the tracestate value. |
@CodingFabian I made it more explicit |
@wu-sheng I think baggage is a separate issue, related to LGTM, except fot the bit about mutating the tracestate. If the suggestion is that "Extremely sensitive systems" should be following the main privacy directive, and not be putting "unkown keys" into their Simply saying "don't put any personally identifiable information in tracestate" should be enough for now, the nuance muddles the message IMHO. |
@tedsuo I realize there are some re-iteration of the same. I intentionally mentioned it as there are services who will want to have an extra level of protection and will want to blacklist. Not talking theoretically =) The language can be cleaned up though and I'd propose we clean it with upcoming editors clean up. Thank you for feedback. If you still believe the language needs to change factually - please file an issue. Haven't meant to disregard your feedback here |
Issues cleaning continued: adding some privacy notes for #55. I'll tag it that issue with
correlation-context
tag once this PR is complete. So it will not be in the main query