Skip to content

Forbid expanded JSON-LD in application/credential+ld+json #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OR13 opened this issue Feb 1, 2023 · 5 comments
Closed

Forbid expanded JSON-LD in application/credential+ld+json #1024

OR13 opened this issue Feb 1, 2023 · 5 comments

Comments

@OR13
Copy link
Contributor

OR13 commented Feb 1, 2023

We should add text that ensures that we don't see:

[
  {
    "@type": [
      "http://schema.org/Person"
    ],
    "http://schema.org/jobTitle": [
      {
        "@value": "Professor"
      }
    ],
    "http://schema.org/name": [
      {
        "@value": "Jane Doe"
      }
    ],
    "http://schema.org/telephone": [
      {
        "@value": "[(425) 123-4567](tel:4251234567)"
      }
    ],
    "http://schema.org/url": [
      {
        "@id": "http://www.janedoe.com/"
      }
    ]
  }
]

or

{
  "@graph": [
    {
      "@type": "http://schema.org/Person",
      "http://schema.org/jobTitle": "Professor",
      "http://schema.org/name": "Jane Doe",
      "http://schema.org/telephone": "[(425) 123-4567](tel:4251234567)",
      "http://schema.org/url": {
        "@id": "http://www.janedoe.com/"
      }
    },
    {
      "@id": "http://www.janedoe.com/"
    }
  ]
}

In credentials or verifiable credentials.

I'd actually like to include examples that are not legal to make this point even clearer.

@bumblefudge
Copy link

bumblefudge commented Feb 2, 2023

Not even for layering on a local @vocab ? 🌶️

@OR13
Copy link
Contributor Author

OR13 commented Feb 2, 2023

@bumblefudge the examples above have no @context, they are produced by applying a context.

Mixing them with things that do have context leads to more confusion.

@bumblefudge
Copy link

thanks for the context that helps

@Sakurann
Copy link
Contributor

PR #1050

@msporny
Copy link
Member

msporny commented Apr 3, 2023

PR #1050 has been merged, which addresses this issue. Closing.

@msporny msporny closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants