Skip to content

Verification #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
David-Chadwick opened this issue Jan 31, 2019 · 5 comments
Closed

Verification #408

David-Chadwick opened this issue Jan 31, 2019 · 5 comments
Assignees
Labels
editorial Purely editorial changes to the specification.

Comments

@David-Chadwick
Copy link
Contributor

Most of our data model document talks about the holder, and refers to the subject much less than to the holder.

However when we get to section 9, Verification, we only address how the subject should be verified, and say nothing about holder verification, when in fact the verifier is only contacted by the holder and may not know anything about the subject (apart from what the presented VCs contain). Consequently there appears to be a gaping hole in the verification section of our document which should be rectified.

@msporny msporny self-assigned this Feb 5, 2019
@burnburn burnburn added the editorial Purely editorial changes to the specification. label Mar 5, 2019
@burnburn
Copy link
Contributor

burnburn commented Mar 5, 2019

@grantnoble to take this (can't assign)

@grantnoble
Copy link

👍

@brentzundel brentzundel assigned msporny and unassigned msporny Mar 5, 2019
@brentzundel
Copy link
Member

brentzundel commented Mar 5, 2019

Decision from F2F Barcelona:

  • @grantnoble will review the verification section for language about subjects and holders and raise a PR to make any needed changes.
  • If that PR is needed, close this after it is merged.

@grantnoble
Copy link

PR #445 to address this issue.

@msporny
Copy link
Member

msporny commented Mar 15, 2019

PR #445 has been merged. Changes have also been applied in 6d157ca that relate to this issue. The issue has been resolved. Please re-open or submit a correcting PR if the issue has not been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Purely editorial changes to the specification.
Projects
None yet
Development

No branches or pull requests

5 participants