Skip to content

Typo in description of Figure 7 #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pchampin opened this issue Apr 27, 2021 · 5 comments
Closed

Typo in description of Figure 7 #775

pchampin opened this issue Apr 27, 2021 · 5 comments
Labels
clarification Non-normative clarifications of spec text editorial Purely editorial changes to the specification. maintenance issues that may be considered part of the work of the maintenance group pending close Close if no objection within 7 days

Comments

@pchampin
Copy link
Contributor

The describing text in §3.3 says:

The verifiablePresentation property in the graph refers to (...)

but it seems to me that it should say

The verifiableCredential property in the graph refers to (...)

@brentzundel
Copy link
Member

The text you indicate is a description of Figure 8, and I believe verifiablePresentation is correct. Perhaps a paragraph break between the text describing figure 7 and the text describing figure 8 would be helpful in clarifying.

@brentzundel brentzundel added editorial Purely editorial changes to the specification. PossibleErratum WG should determine if this is Errata labels Apr 28, 2021
@kuzdogan
Copy link

kuzdogan commented May 3, 2021

@pchampin seems to be right. The full sentence is: "The verifiablePresentation property in the graph refers to one or more verifiable credentials (each a self-contained graph) which in turn contains credential metadata and claims."

Also in Figure 8 the described edge is labeled as verifiableCredential.

@kdenhartog kdenhartog added errata Erratum for a W3C Recommendation maintenance issues that may be considered part of the work of the maintenance group ready for PR This issue is ready for a Pull Request to be created to resolve it v1.1 clarification Non-normative clarifications of spec text and removed PossibleErratum WG should determine if this is Errata errata Erratum for a W3C Recommendation labels Jul 29, 2021
@kdenhartog kdenhartog added this to the V1.1 Completion milestone Jul 29, 2021
@kdenhartog kdenhartog removed this from the V1.1 Completion milestone Aug 13, 2021
@kdenhartog
Copy link
Member

This issue appears to have been addressed in #785

See this line for details, https://github.com/w3c/vc-data-model/pull/785/files#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051R837

Marking as pending close.

@kdenhartog kdenhartog added pending close Close if no objection within 7 days and removed ready for PR This issue is ready for a Pull Request to be created to resolve it labels Aug 30, 2021
@pchampin
Copy link
Contributor Author

Yes, #785 correctly addresses this issue. Thanks.

Not sure if you expect me to close it now, or to close it once #785 is merged.

@brentzundel
Copy link
Member

PR #785 has been merged. With @pchampin agreeing that it addresses this issue, I am closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Non-normative clarifications of spec text editorial Purely editorial changes to the specification. maintenance issues that may be considered part of the work of the maintenance group pending close Close if no objection within 7 days
Projects
None yet
Development

No branches or pull requests

4 participants