Skip to content

Clarify VideoFrame|AudioFrame clone/close/transfer behavior #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chcunningham opened this issue Feb 1, 2021 · 1 comment · Fixed by #167
Closed

Clarify VideoFrame|AudioFrame clone/close/transfer behavior #129

chcunningham opened this issue Feb 1, 2021 · 1 comment · Fixed by #167
Assignees

Comments

@chcunningham
Copy link
Collaborator

Current wording says this is a "deep copy", but makes a note that authors can implement with reference counting under the hood. This has confused at least one user who expected that the "copy" was fine to hold onto.

The text should formalize the reference counting behavior, as it is observable. Additionally, the text should use said behavior in describing new Serailzable and Transferrable characteristics of VideoFrame (what happens when you send to a worker).

@chcunningham chcunningham self-assigned this Feb 1, 2021
@chcunningham chcunningham added this to the Q1 2021 milestone Feb 18, 2021
@chcunningham chcunningham changed the title Clarify VideoFrame clone/close behavior Clarify VideoFrame clone/close/transfer behavior Feb 19, 2021
@chcunningham chcunningham changed the title Clarify VideoFrame clone/close/transfer behavior Clarify VideoFrame|AudioFrame clone/close/transfer behavior Feb 23, 2021
@chcunningham
Copy link
Collaborator Author

Title update to include AudioFrame. The two APIs should match. Working on a PR this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant