Skip to content

Commit 8304fd8

Browse files
Reland "VT: Remove containment requirement."
This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387. This was reverted earlier to wait for CSSWG feedback. The resolution aligns with the behaviour in this patch. w3c/csswg-drafts#8139 Original change's description: > Revert "VT: Remove containment requirement." > > This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. > > Reason for revert: Decided against this feature for now. > > Original change's description: > > VT: Remove containment requirement. > > > > This patch removes the containment requirement from view-transitions. > > > > This is to align with proposed resolution > > w3c/csswg-drafts#7882 > > > > R=​[email protected], [email protected] > > > > Fixed: 1409491 > > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > > Reviewed-by: David Bokan <[email protected]> > > Reviewed-by: Khushal Sagar <[email protected]> > > Commit-Queue: Vladimir Levin <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1096187} > > Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 > Commit-Queue: Vladimir Levin <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096273} Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087 Commit-Queue: Vladimir Levin <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1102856}
1 parent d4af1a3 commit 8304fd8

35 files changed

+116
-213
lines changed

css/css-view-transitions/3d-transform-incoming-ref.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
background: blue;
1616
}
1717
.shared {
18-
contain: layout;
1918
width: 100px;
2019
height: 100px;
2120
}

css/css-view-transitions/3d-transform-incoming.html

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
}
2626
.shared {
2727
view-transition-name: shared;
28-
contain: layout;
2928
width: 100px;
3029
height: 100px;
3130
}
@@ -34,7 +33,6 @@
3433
width: 10px;
3534
height: 10px;
3635
background: red;
37-
contain: layout;
3836
}
3937

4038
::view-transition-group(hidden) { animation-duration: 300s; }

css/css-view-transitions/3d-transform-outgoing-ref.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
background: green;
1010
}
1111
.shared {
12-
contain: layout;
1312
width: 100px;
1413
height: 100px;
1514
}

css/css-view-transitions/3d-transform-outgoing.html

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
}
2727
.shared {
2828
view-transition-name: shared;
29-
contain: layout;
3029
width: 100px;
3130
height: 100px;
3231
}
@@ -35,7 +34,6 @@
3534
width: 10px;
3635
height: 10px;
3736
background: red;
38-
contain: layout;
3937
}
4038

4139
::view-transition-group(hidden) { animation-duration: 300s; }

css/css-view-transitions/css-tags-paint-order-ref.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
<style>
77
div {
8-
contain: layout;
98
position: absolute;
109
top: 50px;
1110
width: 100px;

css/css-view-transitions/css-tags-paint-order.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
<script src="/common/reftest-wait.js"></script>
99
<style>
10-
div { contain: layout; }
1110
#one {
1211
background: green;
1312
width: 100px;

css/css-view-transitions/dialog-in-top-layer-during-transition-new.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
padding: 0;
1818

1919
view-transition-name: dialog;
20-
contain: layout;
21-
2220
outline: none;
2321
}
2422

@@ -28,7 +26,6 @@
2826
background: grey;
2927

3028
view-transition-name: backdrop;
31-
contain: layout;
3229
}
3330

3431
.hidden {

css/css-view-transitions/dialog-in-top-layer-during-transition-old.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
padding: 0;
1818

1919
view-transition-name: dialog;
20-
contain: layout;
21-
2220
outline: none;
2321
}
2422

@@ -28,7 +26,6 @@
2826
background: grey;
2927

3028
view-transition-name: backdrop;
31-
contain: layout;
3229
}
3330

3431
.hidden {

css/css-view-transitions/element-with-overflow.html

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,12 @@
1212
height: 10px;
1313
view-transition-name: hidden;
1414
background: green;
15-
contain: layout;
1615
}
1716

1817
.target {
1918
width: 100px;
2019
height: 100px;
2120
background: lightblue;
22-
contain: layout;
2321
view-transition-name: target;
2422
}
2523
.inner {
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
<!DOCTYPE html>
2+
<html class=reftest-wait>
3+
<title>View transitions: element with fixed position descendant</title>
4+
<link rel="help" href="https://github.com/WICG/view-transitions">
5+
<link rel="author" href="mailto:[email protected]">
6+
<link rel="match" href="named-element-with-fix-pos-child-ref.html">
7+
<script src="/common/reftest-wait.js"></script>
8+
<style>
9+
.target {
10+
width: 100px;
11+
height: 100px;
12+
background: blue;
13+
view-transition-name: target;
14+
}
15+
.child {
16+
width: 100px;
17+
height: 100px;
18+
position: fixed;
19+
top: 150px;
20+
left: 150px;
21+
background: grey;
22+
}
23+
24+
html::view-transition-group(target) { animation-duration: 300s; }
25+
html::view-transition-old(target) { animation: unset; opacity: 0; }
26+
html::view-transition-new(target) {
27+
animation: unset;
28+
opacity: 1;
29+
}
30+
</style>
31+
32+
<div class=target>
33+
<div class=child></div>
34+
</div>
35+
36+
<script>
37+
failIfNot(document.startViewTransition, "Missing document.startViewTransition");
38+
39+
async function runTest() {
40+
document.startViewTransition(() =>
41+
requestAnimationFrame(() => requestAnimationFrame(takeScreenshot)));
42+
}
43+
onload = () => requestAnimationFrame(() => requestAnimationFrame(runTest));
44+
</script>
45+

0 commit comments

Comments
 (0)