Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

4.x compatibility issues with 1.x #5189

@nazarhussain

Description

@nazarhussain

Found some compatibility issues for 4.x those needs to be addressed to further investigate the breaking changes.

  • Contract constructor does not support swapping parameters. a.k.a. As second parameter you can only pass the address, but in 1.x you can either pass address or contract options.
  • In 1.x the contract.deploy works with the ABI without any constructor definition and assumes empty arguments for it.
  • In 1.x the contract.deploy().estimateGas() does not require to specify the address.
  • Transaction confirmation event is returning the confirmations number which are not aligned with 1.x.
  • Transaction PromiEvent does not support error event.
  • Transaction PromiEvent have mixed types for event data, it have to be consistent with the ReturnFormat user specified.
  • Contract method getPastEvents with the option {fromBlock: 0} does not work
  • Contract method getPastEvents does not return right event name when called with allEvents
  • Contract event object didn't have the id attribute
  • Contract event object have attribute returnValue instead of returnValues

Metadata

Metadata

Assignees

Labels

4.x4.0 relatedBugAddressing a bug

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions