use eslint-config-i-am-meticulous + --fix

Author: MoOx

.eslintrc

@@ -3,8 +3,10 @@
 var assign = require("object-assign");
 var loaderUtils = require("loader-utils");
 var objectHash = require("object-hash");
-var pkg = require("./package.json");
 var createCache = require("loader-fs-cache");
+
+var pkg = require("./package.json");
+
 var cache = createCache("eslint-loader");
 
 var engines = {};

index.js

@@ -29,8 +29,10 @@
   "devDependencies": {
     "ava": "^0.17.0",
     "eslint": "^5.1.0",
+    "eslint-config-i-am-meticulous": "^11.0.0",
     "eslint-friendly-formatter": "^2.0.4",
     "husky": "^0.14.3",
+    "mkdirp": "^0.5.1",
     "npmpub": "^4.0.1",
     "prettier": "^1.13.7",
     "pretty-quick": "^1.6.0",
@@ -43,6 +45,13 @@
     "test": "npm run lint && npm run ava",
     "release": "npmpub"
   },
+  "eslintConfig": {
+    "extends": "eslint-config-i-am-meticulous",
+    "rules": {
+      "no-var": 0,
+      "prefer-const": 0
+    }
+  },
   "ava": {
     "files": [
       "test/*.js"

package.json

@@ -1,7 +1,9 @@
+var fs = require("fs");
+
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
-var fs = require("fs");
 
 // clone the "fixable" file, so that we do not lose the original contents
 // when the fixes are applied to disk

test/autofix.js

@@ -1,8 +1,10 @@
-var test = require("ava");
 var fs = require("fs");
 var path = require("path");
+
+var test = require("ava");
 var assign = require("object-assign");
 var rimraf = require("rimraf");
+var mkdirp = require("mkdirp");
 var webpack = require("webpack");
 
 var defaultCacheDir = path.join(
@@ -252,7 +254,6 @@ test.cb.serial("should generate a new file if the identifier changes", t => {
   });
 });
 
-var mkdirp = require("mkdirp");
 function createTestDirectory(baseDirectory, testTitle, cb) {
   const directory = path.join(baseDirectory, escapeDirectory(testTitle));
 

test/cache.js

@@ -1,5 +1,6 @@
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
 
 test.cb("eslint-loader can return error if file is bad", function(t) {

test/error.js

@@ -1,6 +1,8 @@
 var path = require("path");
+
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
 
 test.cb(

test/eslint-path.js

@@ -1,5 +1,6 @@
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
 
 test.cb("eslint-loader ignores files present in .eslintignore", function(t) {

test/eslintignore.js

@@ -0,0 +1,62 @@
+var test = require("ava");
+var webpack = require("webpack");
+
+var conf = require("./utils/conf");
+
+test.cb("emits errors in async mode", function(t) {
+  t.plan(1);
+  webpack(
+    conf(
+      {
+        cache: true,
+        entry: "./test/fixtures/error.js"
+      },
+      {
+        failOnError: true,
+        emitError: true,
+        cache: true
+      }
+    ),
+    function(err, stats) {
+      if (err) {
+        throw err;
+      }
+
+      // console.log(stats.compilation.errors)
+      t.true(
+        stats.hasErrors(),
+        "a file that contains eslint errors should return error"
+      );
+      t.end();
+    }
+  );
+});
+
+test.cb("correctly indentifies a success", function(t) {
+  t.plan(1);
+  webpack(
+    conf(
+      {
+        cache: true,
+        entry: "./test/fixtures/good.js"
+      },
+      {
+        failOnError: true,
+        emitError: true,
+        cache: true
+      }
+    ),
+    function(err, stats) {
+      if (err) {
+        throw err;
+      }
+
+      // console.log(stats.compilation.errors)
+      t.false(
+        stats.hasErrors(),
+        "a file that doesn't contains eslint errors should not return errors"
+      );
+      t.end();
+    }
+  );
+});

test/fail-on-error-async-and-emit.js

@@ -1,5 +1,6 @@
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
 
 test.cb("eslint-loader can force to emit error", function(t) {

test/fail-on-error/async-and-emit.js

@@ -1,5 +1,6 @@
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
 
 test.cb("eslint-loader can force to emit warning", function(t) {

test/force-emit-error.js

@@ -1,6 +1,7 @@
 /* eslint-disable no-console */
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
 
 test.cb("eslint-loader can use custom formatter", function(t) {

test/force-emit-warning.js

@@ -1,6 +1,7 @@
 /* eslint-disable no-console */
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
 
 test.cb("eslint-loader can use eslint formatter", function(t) {

test/formatter-custom.js

@@ -1,8 +1,10 @@
+var fs = require("fs");
+var path = require("path");
+
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
-var fs = require("fs");
-var path = require("path");
 
 test.cb(
   "eslint-loader can be configured to write multiple eslint result files",

test/formatter-eslint.js

@@ -1,8 +1,10 @@
 /* eslint-disable no-console */
+var fs = require("fs");
+
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
-var fs = require("fs");
 
 test.cb(
   "eslint-loader can be configured to write eslint results to a file",

test/formatter-multiple-entries.js

@@ -1,5 +1,6 @@
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
 
 test.cb("eslint-loader will create an engine for each unique config", function(

test/formatter-write.js

@@ -1,5 +1,6 @@
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
 
 test.cb("eslint-loader don't throw error if file is ok", function(t) {

test/multiple-engines.js

@@ -1,5 +1,6 @@
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
 
 test.cb("eslint-loader supports query strings parameters", function(t) {

test/ok.js

@@ -1,5 +1,6 @@
 var test = require("ava");
 var webpack = require("webpack");
+
 var conf = require("./utils/conf");
 
 test.cb(

test/parameters.js

@@ -1,24 +1,25 @@
-var path = require("path")
-var assign = require("object-assign")
+var path = require("path");
 
-var webpack = require("webpack")
-var webpackVersion = require("./version.js")
+var assign = require("object-assign");
+var webpack = require("webpack");
+
+var webpackVersion = require("./version.js");
 
 var DEFAULT_CONFIG = {
   output: {
     path: path.join(__dirname, "..", "output") + path.sep,
-    filename: "bundle.js",
+    filename: "bundle.js"
   },
   module: {
     rules: [
       {
         test: /\.js$/,
         use: "./index",
-        exclude: /node_modules/,
-      },
-    ],
-  },
-}
+        exclude: /node_modules/
+      }
+    ]
+  }
+};
 
 /**
  * Returns a valid config for both webpack versions 1 and 2.
@@ -27,29 +28,28 @@ var DEFAULT_CONFIG = {
  * @returns {Object}
  */
 module.exports = function conf(webpackConf, loaderConf) {
-  var mode = webpackVersion < 4 ? {} : {mode: "development"}
+  var mode = webpackVersion < 4 ? {} : { mode: "development" };
 
   loaderConf = {
-    eslint: assign({
-      // this disables the use of .eslintignore, since it contains the fixtures
-      // folder to skip it on the global linting, but here we want the opposite
-      // (we only use .eslintignore on the test that checks this)
-      ignore: false,
-    }, loaderConf),
-  }
+    eslint: assign(
+      {
+        // this disables the use of .eslintignore, since it contains the fixtures
+        // folder to skip it on the global linting, but here we want the opposite
+        // (we only use .eslintignore on the test that checks this)
+        ignore: false
+      },
+      loaderConf
+    )
+  };
 
   // webpack v2 requires them to be added via the LoaderOptionsPlugin
   // webpack v4 needs mode option
-  return assign(DEFAULT_CONFIG,
-    mode,
-    webpackConf,
-    {
-      plugins: [
-        new webpack.LoaderOptionsPlugin({
-          exclude: /node_modules/,
-          options: loaderConf,
-        }),
-      ],
-    }
-  )
-}
+  return assign(DEFAULT_CONFIG, mode, webpackConf, {
+    plugins: [
+      new webpack.LoaderOptionsPlugin({
+        exclude: /node_modules/,
+        options: loaderConf
+      })
+    ]
+  });
+};