Skip to content

fix: add missing return statement #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

inottn
Copy link
Contributor

@inottn inottn commented Feb 7, 2025

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

The change ensures that the contextify function returns the result of loaderContext.utils.contextify when it is called, instead of just calling it without returning its result.

Breaking Changes

No

Additional Info

No

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.75%. Comparing base (9c8c58c) to head (e2aa27c).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   82.26%   73.75%   -8.52%     
==========================================
  Files           4        4              
  Lines         141      141              
  Branches       51       51              
==========================================
- Hits          116      104      -12     
- Misses         16       24       +8     
- Partials        9       13       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-akait alexander-akait merged commit bc741a0 into webpack-contrib:master Feb 7, 2025
16 of 17 checks passed
@alexander-akait
Copy link
Member

Thanks

@inottn inottn deleted the fix/return branch February 7, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants