Skip to content

Cite prehtml-loader in documentation ? #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 5 tasks
denis-migdal opened this issue Jan 13, 2020 · 4 comments
Closed
1 of 5 tasks

Cite prehtml-loader in documentation ? #206

denis-migdal opened this issue Jan 13, 2020 · 4 comments

Comments

@denis-migdal
Copy link

denis-migdal commented Jan 13, 2020

Documentation Is:

  • Missing
  • Needed
  • Confusing
  • Not Sure?
  • Other

Please Explain in Detail...

I just created a new loader that can be chained with html-loader, that enables to provide parameters for html-loader interpolation:
https://github.com/denis-migdal/prehtml-loader

This seems to be an asked feature, as shown by the following issues:
#120
#122
#184

(sorry if I flooded a little the issues).

Your Proposal for Changes

Could it be possible to cite my loader in your documentation ?

This is my first npm package, so if you have any suggestion on what I should to, feel free to create an issue in my git repository:
https://github.com/denis-migdal/prehtml-loader/issues

@alexander-akait
Copy link
Member

Yes, PR welcome

@denis-migdal
Copy link
Author

denis-migdal commented Jan 13, 2020

Thanks for your reply.

I will try to submit a PR in few hours.

I am currently adding 2 extra-features to my loader:

  • support of import (convert it into a require) for html-loader;
  • support of templates (I am currently thinking how to achieve this).

@denis-migdal
Copy link
Author

Done: #211

Please note that my loader is very new (today), so I can't guarantee that there will be no issues.

@alexander-akait
Copy link
Member

Thanks for the issue, i think will be great to put thath into https://github.com/webpack-contrib/awesome-webpack repo, feel free to send a PR 👍 You can add examples to own README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants