feat: added typescript/recommended preset

Author: alexander-akait

.github/workflows/test.yml

@@ -30,3 +30,5 @@ jobs:
         with:
           flags: integration
           token: ${{ secrets.CODECOV_TOKEN }}
+      - run: node ./validation/my-other-code.ts && node ./validation/my-other-code.ts && node ./validation/my-other-code.ts
+        if: matrix.node-version == '24.x'

configs.js

@@ -60,10 +60,11 @@ const cache = new Cache();
  *
  * Don't cache the data.
  * @param {string} dir The path to a directory to read.
+ * @param {string} filename The filename.
  * @returns {import('type-fest').JsonObject|null} The read `package.json` data, or null.
  */
-function readPackageJson(dir) {
-	const filePath = path.join(dir, "package.json");
+function readJsonFile(dir, filename) {
+	const filePath = path.join(dir, filename);
 	try {
 		const text = fs.readFileSync(filePath, "utf8");
 		const data = JSON.parse(text);
@@ -87,29 +88,30 @@ function readPackageJson(dir) {
 /**
  * Gets a `package.json` data.
  * The data is cached if found, then it's used after.
+ * @param {string} filename The filename.
  * @param {string=} startPath A file path to lookup.
  * @returns {import('type-fest').JsonObject | null} A found `package.json` data or `null`.
  * This object have additional property `filePath`.
  */
-function getPackageJson(startPath = "a.js") {
+function getJsonFile(filename, startPath = "a.js") {
 	const startDir = path.dirname(path.resolve(startPath));
 	let dir = startDir;
 	let prevDir = "";
 	let data = null;
 
 	do {
-		data = cache.get(dir);
+		data = cache.get(dir + filename);
 		if (data) {
 			if (dir !== startDir) {
-				cache.set(startDir, data);
+				cache.set(startDir + filename, data);
 			}
 			return data;
 		}
 
-		data = readPackageJson(dir);
+		data = readJsonFile(dir, filename);
 		if (data) {
-			cache.set(dir, data);
-			cache.set(startDir, data);
+			cache.set(dir + filename, data);
+			cache.set(startDir + filename, data);
 			return data;
 		}
 
@@ -118,11 +120,11 @@ function getPackageJson(startPath = "a.js") {
 		dir = path.resolve(dir, "..");
 	} while (dir !== prevDir);
 
-	cache.set(startDir, null);
+	cache.set(startDir + filename, null);
 	return null;
 }
 
-const packageJson = getPackageJson();
+const packageJson = getJsonFile("package.json");
 const isModule =
 	packageJson !== null &&
 	typeof packageJson === "object" &&
@@ -194,7 +196,7 @@ function getJavascriptConfig() {
 /**
  * @returns {Promise<Record<string, string>>} config
  */
-function getTypescriptJsdocConfig() {
+function getTypescriptJSdocConfig() {
 	if (packageJson === null) {
 		return [];
 	}
@@ -208,6 +210,37 @@ function getTypescriptJsdocConfig() {
 		: [];
 }
 
+/**
+ * @returns {Promise<Record<string, string>>} config
+ */
+function getTypescriptConfig() {
+	if (packageJson === null) {
+		return [];
+	}
+
+	const dependencies = packageJson.dependencies || [];
+	const devDependencies = packageJson.devDependencies || [];
+
+	if (
+		typeof dependencies.typescript === "undefined" &&
+		typeof devDependencies.typescript === "undefined"
+	) {
+		return [];
+	}
+
+	const tsconfigJson = getJsonFile("tsconfig.json");
+	const isStrict =
+		(tsconfigJson &&
+			tsconfigJson.compilerOptions &&
+			tsconfigJson.compilerOptions.strict) ||
+		true;
+
+	return [
+		configs["typescript/recommended"],
+		isStrict ? { rules: { strict: "off" } } : {},
+	];
+}
+
 /**
  * @returns {Promise<Record<string, string>>} config
  */
@@ -225,44 +258,53 @@ function getJestConfig() {
 		: [];
 }
 
+const javascriptConfig = getJavascriptConfig();
+const typescriptJSDocConfig = getTypescriptJSdocConfig();
+const typescriptConfig = getTypescriptConfig();
+const jestConfig = getJestConfig();
+
 configs.recommended = [
 	globalIgnores(ignorePaths),
 	isModule
 		? configs["node/mixed-module-and-commonjs"]
 		: configs["node/mixed-commonjs-and-module"],
-	getJavascriptConfig(),
-	getTypescriptJsdocConfig(),
-	getJestConfig(),
+	javascriptConfig,
+	typescriptJSDocConfig,
+	typescriptConfig,
+	jestConfig,
 	configs["markdown/recommended"],
 	configs["stylistic/recommended"],
 ];
 
 configs["recommended-module"] = [
 	globalIgnores(ignorePaths),
 	configs["node/mixed-module-and-commonjs"],
-	getJavascriptConfig(),
-	getTypescriptJsdocConfig(),
-	getJestConfig(),
+	javascriptConfig,
+	typescriptJSDocConfig,
+	typescriptConfig,
+	jestConfig,
 	configs["markdown/recommended"],
 	configs["stylistic/recommended"],
 ];
 
 configs["recommended-commonjs"] = [
 	globalIgnores(ignorePaths),
 	configs["node/mixed-commonjs-and-module"],
-	getJavascriptConfig(),
-	getTypescriptJsdocConfig(),
-	getJestConfig(),
+	javascriptConfig,
+	typescriptJSDocConfig,
+	typescriptConfig,
+	jestConfig,
 	configs["markdown/recommended"],
 	configs["stylistic/recommended"],
 ];
 
 configs["recommended-dirty"] = [
 	globalIgnores(ignorePaths),
 	configs["node/mixed-dirty"],
-	getJavascriptConfig(),
-	getTypescriptJsdocConfig(),
-	getJestConfig(),
+	javascriptConfig,
+	typescriptJSDocConfig,
+	typescriptConfig,
+	jestConfig,
 	configs["markdown/recommended"],
 	configs["stylistic/recommended"],
 ];

configs/javascript.js

@@ -2,6 +2,7 @@ import globals from "globals";
 import javascriptConfig from "@eslint/js";
 import unicornPlugin from "eslint-plugin-unicorn";
 import importPlugin from "eslint-plugin-import";
+import { allExtensions } from "./utils/extensions.js";
 
 const possibleProblems = {
 	"array-callback-return": [
@@ -403,7 +404,9 @@ const suggestions = {
 		},
 	],
 
-	"no-implicit-globals": "error",
+	// No need
+	// Make sense only for `browser` configuration for old browsers
+	// "no-implicit-globals": "off",
 
 	"no-implied-eval": "error",
 
@@ -1078,7 +1081,7 @@ const importRules = {
 	// From recommended
 	"import/no-unresolved": [
 		"error",
-		{ ignore: ["^eslint/config$"], commonjs: true },
+		{ ignore: ["^eslint/config$", "^typescript-eslint$"], commonjs: true },
 	],
 
 	// No need
@@ -1152,10 +1155,6 @@ const importRules = {
 	// "import/prefer-default-export": "off",
 };
 
-const typeScriptExtensions = [".ts", ".cts", ".mts", ".tsx"];
-const javascriptExtensions = [".js", ".jsx", ".mjs", ".cjs"];
-const allExtensions = [...typeScriptExtensions, ...javascriptExtensions];
-
 /**
  * @param {number} esVersion es version
  * @returns {Record<string, string | number>} config
@@ -1164,7 +1163,7 @@ function getConfig(esVersion) {
 	const config = {
 		...javascriptConfig.configs.recommended,
 		name: `javascript/es${esVersion}`,
-		files: ["**/*.{js,jsx,mjs,cjs}"],
+		files: [`**/*.{${allExtensions.map((item) => item.slice(1)).join(",")}}`],
 		settings: {
 			"import/extensions": allExtensions,
 			"import/ignore": [
@@ -1173,7 +1172,7 @@ function getConfig(esVersion) {
 			],
 			"import/resolver": {
 				node: {
-					extensions: allExtensions,
+					extensions: [...allExtensions],
 				},
 			},
 		},