Skip to content

Commit 4e1ab38

Browse files
authored
Merge branch 'master' into handle-array-paths
2 parents 557e9e3 + 3d9288a commit 4e1ab38

File tree

10 files changed

+26
-8
lines changed

10 files changed

+26
-8
lines changed

CHANGELOG.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,21 @@
22

33
All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
44

5+
## [3.7.0](https://github.com/webpack/webpack-dev-server/compare/v3.5.1...v3.7.0) (2019-06-06)
6+
7+
8+
### Bug Fixes
9+
10+
* change clientLogLevel order to be called first ([#1973](https://github.com/webpack/webpack-dev-server/issues/1973)) ([57c8c92](https://github.com/webpack/webpack-dev-server/commit/57c8c92))
11+
* es6 syntax in client ([#1982](https://github.com/webpack/webpack-dev-server/issues/1982)) ([802aa30](https://github.com/webpack/webpack-dev-server/commit/802aa30))
12+
13+
14+
### Features
15+
16+
* **server:** add serverMode option ([#1937](https://github.com/webpack/webpack-dev-server/issues/1937)) ([44a8cde](https://github.com/webpack/webpack-dev-server/commit/44a8cde))
17+
18+
19+
520
## [3.6.0](https://github.com/webpack/webpack-dev-server/compare/v3.5.1...v3.6.0) (2019-06-05)
621

722

File renamed without changes.
File renamed without changes.

lib/utils/updateCompiler.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*/
77
const webpack = require('webpack');
88
const addEntries = require('./addEntries');
9-
const SockJSClient = require('./../clients/SockJSClient');
109

1110
function updateCompiler(compiler, options) {
1211
if (options.inline !== false) {
@@ -51,7 +50,10 @@ function updateCompiler(compiler, options) {
5150
compiler.hooks.entryOption.call(config.context, config.entry);
5251

5352
const providePlugin = new webpack.ProvidePlugin({
54-
__webpack_dev_server_client__: SockJSClient.getClientPath(options),
53+
// SockJSClient.getClientPath(options)
54+
__webpack_dev_server_client__: require.resolve(
55+
'../../client/clients/SockJSClient.js'
56+
),
5557
});
5658
providePlugin.apply(compiler);
5759
});

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "webpack-dev-server",
3-
"version": "3.6.0",
3+
"version": "3.7.0",
44
"description": "Serves a webpack app. Updates the browser on changes.",
55
"bin": "bin/webpack-dev-server.js",
66
"main": "lib/Server.js",
@@ -24,8 +24,9 @@
2424
"test:watch": "npm run test:coverage --watch",
2525
"test": "npm run test:coverage",
2626
"pretest": "npm run lint",
27-
"prepare": "rimraf ./ssl/*.pem && npm run -s transpile:index && npm run -s build:live && npm run -s build:index && npm run -s build:sockjs",
27+
"prepare": "rimraf ./ssl/*.pem && npm run -s transpile:index && npm run transpile:clients && npm run -s build:live && npm run -s build:index && npm run -s build:sockjs",
2828
"transpile:index": "babel client-src/default --out-dir client --ignore \"./client-src/default/*.config.js\"",
29+
"transpile:clients": "babel client-src/clients --out-dir client/clients",
2930
"build:index": "webpack ./client-src/default/index.js -o client/index.bundle.js --color --config client-src/default/webpack.config.js",
3031
"build:live": "webpack ./client-src/live/index.js -o client/live.bundle.js --color --config client-src/live/webpack.config.js",
3132
"build:sockjs": "webpack ./client-src/sockjs/index.js -o client/sockjs.bundle.js --color --config client-src/sockjs/webpack.config.js",

test/SockJSClient.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
const http = require('http');
44
const express = require('express');
55
const sockjs = require('sockjs');
6-
const SockJSClient = require('../lib/clients/SockJSClient');
6+
const SockJSClient = require('../client-src/clients/SockJSClient');
77

88
describe('SockJSClient', () => {
99
let socketServer;

test/e2e/ProvidePlugin.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const testServer = require('../helpers/test-server');
44
const config = require('../fixtures/provide-plugin-config/webpack.config');
55
const runBrowser = require('../helpers/run-browser');
66

7-
describe('ProvidePlugin', () => {
7+
describe.skip('ProvidePlugin', () => {
88
describe('inline', () => {
99
beforeAll((done) => {
1010
const options = {

test/fixtures/provide-plugin-config/foo.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
const SockJSClient = require('../../../lib/clients/SockJSClient');
3+
const SockJSClient = require('../../../client-src/clients/SockJSClient');
44

55
window.expectedClient = SockJSClient;
66
// eslint-disable-next-line camelcase, no-undef

0 commit comments

Comments
 (0)