Skip to content

Update Examples And Add Hotness #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 14, 2017
Merged

Update Examples And Add Hotness #1183

merged 7 commits into from
Nov 14, 2017

Conversation

shellscape
Copy link
Contributor

What kind of change does this PR introduce?
This refactors and updates the examples.
Provides a significant UX and README update for each example.

Did you add or update the examples/?
You betcha

Summary
The examples weren't pretty. Grammar and layout of READMEs also updated. Consolidates code shared commonly between examples.

Does this PR introduce a breaking change?
No

@codecov
Copy link

codecov bot commented Nov 14, 2017

Codecov Report

Merging #1183 into master will decrease coverage by 0.16%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1183      +/-   ##
==========================================
- Coverage    76.9%   76.74%   -0.17%     
==========================================
  Files           5        5              
  Lines         472      473       +1     
  Branches      151      151              
==========================================
  Hits          363      363              
- Misses        109      110       +1
Impacted Files Coverage Δ
lib/Server.js 83.58% <50%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e501c8...28a44d9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant